Repository navigation
fix: Reporting rate meta + agg. totals [DHIS2-22013] - #25520
Merged
Merged
Conversation
maikelarabori
added
run-api-analytics-tests
|
luciano-fiandesio
approved these changes
Oct 6, 2026
enricocolasante
approved these changes
Oct 7, 2026
This was referenced Oct 7, 2026
maikelarabori
added a commit
that referenced
this pull request
Oct 8, 2026
maikelarabori
added a commit
that referenced
this pull request
Oct 8, 2026
* fix: Reporting rate meta + agg. totals [DHIS2-22013] (#25520) * fix: Reporting rate meta + agg. totals [DHIS2-22013] * fix: Redundant modifier [DHIS2-22013] * fix: Compilation issue [DHIS2-22013]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the aggregation return type for reporting rates values, as well as the respective metadata.
I also fixed a bug found in legendsets, where some methods had to be overridden to ensure the correct behaviour. Otherwise, the invoked method from the superclass will always return null/false in all cases.
Some e2e tests were adjusted, and a few new unit tests were added.