Skip to content

test: guard against clicking disabled slideshow button (DHIS2-21933) #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karolinelien merged 2 commits into from
Aug 31, 2026
Merged

test: guard against clicking disabled slideshow button (DHIS2-21933) #3337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20f001f
test: de-flake slideshow Cypress spec
karolinelien Aug 31, 2026
3cfe765
Merge branch 'master' into test/deflake-slideshow-cypress
karolinelien Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cypress/integration/slideshow.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ describe('Slideshow functionality', () => {
assertNormalViewIsShown()

// Click the slideshow button
cy.get('button').contains('Slideshow').realClick()
cy.getByDataTest('enter-slideshow-button')
.should('not.be.disabled')
.realClick()

// Assert fullscreen mode is shown
assertSlideshowControlbar()
Expand Down Expand Up @@ -211,7 +213,9 @@ describe('Slideshow functionality', () => {
assertNormalViewIsShown()

// Click the slideshow button
cy.get('button').contains('Slideshow').realClick()
cy.getByDataTest('enter-slideshow-button')
.should('not.be.disabled')
.realClick()

// Assert fullscreen mode is shown
assertSlideshowControlbar()
Expand Down Expand Up @@ -240,7 +244,7 @@ describe('Slideshow functionality', () => {
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(11000) // Wait for the autoplay to switch to the next item

// // Assert item 2 is shown after autoplay starts
// Assert item 2 is shown after autoplay starts
assertOnlyItem2IsVisible()

// eslint-disable-next-line cypress/no-unnecessary-waiting
Expand Down
Loading