Repository navigation
refactor(esa-cci): remove the ESA CCI land cover datasets, now in OCS core - #29
Merged
Merged
Conversation
open-climate-service#477 ships esacci_landcover_class_yearly, so the class template and plugin go from here. The fractions dataset stays, its tests reading the classes through the shared loader.
There was a problem hiding this comment.
🟢 Approval recommended
The merged core replacement covers the removed dataset, and the focused cleanup preserves fractions behavior with no identified blocking issues.
No open issues 🎉
What changed in this PR
Removes the duplicate ESA CCI land-cover class dataset now provided by OCS core, while retaining the grouped land-cover fractions dataset.
Changes:
- Removes the local class plugin and dataset template.
- Updates documentation to direct per-class aggregation to OCS core.
- Adapts tests to use the shared class loader and preserves CRS and time-axis checks in the fractions test.
| File | Description |
|---|---|
tests/test_esa_cci_lc_plugin.py |
Replaces class-plugin calls and retains relevant assertions. |
README.md |
Lists only the fractions dataset and notes core ownership of the class map. |
ocs_plugins/rasters/esa_cci_lc.yaml |
Removes the class template and documents core class aggregation. |
ocs_plugins/rasters/esa_cci_lc.py |
Removes the class plugin while leaving fractions behavior unchanged. |
Review effort: Balanced
Per-district shares come from OCS core's esacci_landcover_class_yearly with aggregate_spatial_classes, and grouped through esacci_landcover_groups, so the ingest-time fractions are no longer needed. Nothing ESA CCI is left in this package.
turban
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-climate-service#477 is merged, so OCS core ships
esacci_landcover_class_yearly, with its classes and colours. Both ESA CCI datasets go from here:esacci_landcover_class_yearly: the same dataset id is no longer defined twice.esacci_landcover_fraction_yearly: it precomputed group shares per 1 km cell at ingest. Shares per district now come from the core class dataset withaggregate_spatial_classes, at native 300 m resolution, and grouped into the same ten groups with theesacci_landcover_groupsworkflow (feat(processes): land cover groups with remap_classes and an ESA CCI workflow #30).The plugin module, its templates and tests, and the README row are removed.
_netcdf.pystays; other plugins use it.Sending a per-district group share to DHIS2 still needs a change in OCS core's export: CLIM-1575.