Repository navigation
feat(copdem90): a static dataset without a time axis - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With dhis2/open-climate-service#470, a dataset can leave out
period_type: it has no time axis, its plugin implementsfetch(bbox), and the store is(y, x).copdem90_elevation_staticnow works like core'scopdem30_elevation_static:period_typeor temporal extent,sync: kind: static. It was a one-year series with 2021, the release year, as a fake period.fetch(bbox)replacesperiods()andfetch_period(), and no time axis is added. Tile selection and the mosaic are unchanged.fetchand check the result is(y, x).mainthat includes #470.An existing store has a
taxis, so it needs ingesting again withoverwrite.Verified on the Nepal test instance: re-ingested in 27 s as a
(y, x)store (4921 x 9781, highest cell 8,726 m), with no period type or time range on the dataset, and a thumbnail. Tests pass and lint is clean.