Repository navigation
fix(mcdwd): offer only the days asked for, not a composite starting the day before - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingesting
modis_flood_dailyfailed for any day, with OCS answeringSource cannot materialize the requested temporal scope from 2026-10-15; first available is 2026-10-14.The product is a 2-day composite, so the granule starting on the 14th overlaps the 15th, and the CMR search for the 15th returns it.
periods()listed every granule's start day, so it offered the 14th for a request for the 15th, and OCS refuses a source that starts before the requested day.periods()now keeps only the days within the requested range;fetch_periodalready filtered by day.Found ingesting a sample of every data source on the Nepal test instance. A new test returns a composite starting the day before and checks only the requested day is offered; it fails without the fix.