Repository navigation
fix(esa-cci-lc): use the CF method area: mean in cell_methods - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused metadata correction and regression check have no identified blocking issues; tests were not executed.
No open issues 🎉
What changed in this PR
Corrects ESA CCI land-cover metadata so CF-aware readers can interpret the fraction values.
Changes:
- Replaces
area: fractionwitharea: mean. - Adds a regression check for CF method names across templates.
| File | Description |
|---|---|
| tests/test_discovery.py | Validates template cell_methods against CF method names. |
| ocs_plugins/rasters/esa_cci_lc.yaml | Uses area: mean for land-cover fractions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESA CCI land cover fraction template set
cell_methodstoarea: fraction, which is not a CF method, so CF-aware readers do not understand it. Each value is the share of a cell's observed pixels in a class group, which is a mean of a 1/0 indicator over the area:area: mean.A new test in
tests/test_discovery.pychecks that every template'scell_methodsuses CF method names. It fails on the old value. OCS core has the same check for its built-in templates since PR #484 (CLIM-1484).Existing stores keep the old value until re-ingested.