Repository navigation
chore: enable ruff security rules and update dependencies (CLIM-1536) - #153
Merged
Merged
Conversation
Fix the findings in product code (asserts used for control flow, a bare except-pass) and suppress the intended ones (pickle of the service's own training workspace, exec in export, seeded random data). Tests, scripts and examples ignore the rules that only matter for product code.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mortenoh
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S(flake8-bandit) rules.asserts inchapkit artifactwith explicit checks (asserts vanish underpython -O), and narrow a bareexcept Exception: passin project discovery toOSError/TOMLDecodeError.ml/manager.py),execof the project'smain.pyinchapkit mlproject export, the random data seed inchapkit test.scripts/,examples/and the seeded data generator.>=3.1.0).uv lock --upgradeahead of the release (fastapi 0.162, starlette 1.10, pandas 3.1, polars 2.1, sqlalchemy 2.1.6, python-dateutil 3.0, among others).Note:
run_shell(utils.py) usesasyncio.create_subprocess_shell, which theSrules do not cover; that belongs with the review findings rather than this change.Test plan
make lint(ruff, mypy, pyright)uv run pytestwith all extras (1103 passed)Jira: CLIM-1536