fix(build): support VS 2026 CRT layout - #83
Conversation
Visual Studio 2026 names its app-local runtime VC145 while the release packager assumed VC143. Discover the sole CRT family inside the exact selected redist version and fail closed on missing or ambiguous layouts.
|
@cursor review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 08f2a37. Configure here.
|
@codex review |
|
@cursor review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 08f2a37. Configure here.
Summary
VC143and Visual Studio 2026VC145layoutsVerification
python -m unittest scripts.test_build_runtime -v(9/9)python -m unittest discover -s scripts -p test_*.py(50/50)python scripts/check_release_workflow.pygit diff --checkFixes the non-publishing Mod Manager RC smoke-build failure in Actions run 31631888357. All quality gates in that run were green; packaging failed before verification/upload because the VS 2026 runner no longer uses the hard-coded
Microsoft.VC143.CRTleaf.Note
Medium Risk
Changes release packaging for gore-mod-manager only, but failures are fail-closed before signing and the behavior is heavily unit-tested; wrong CRT selection would break portable/installer builds on CI.
Overview
Fixes Mod Manager Windows packaging on Visual Studio 2026 runners, where the app-local MSVC runtime path is no longer a fixed
Microsoft.VC143.CRTleaf.build.pyadds_msvc_crt_dirto scan the x64 redist directory for exactly one realMicrosoft.VC*.CRTdirectory (skipping symlinks/junctions), then uses that folder when stagingmsvcp140/vcruntime140DLLs. Resolution is tightened so the chosen CRT directory must stay under its redistx64folder.scripts/test_build_runtime.pyparametrizes the fake VS layout (toolset, redist version, CRT family), adds a VC145 staging test, and asserts missing or duplicate CRT families raise beforesign_pathsruns and leave the bundle unchanged.Reviewed by Cursor Bugbot for commit 08f2a37. Bugbot is set up for automated code reviews on this repo. Configure here.