Skip to content

fix(build): support VS 2026 CRT layout - #83

Merged
dh0er merged 1 commit into
mainfrom
codex/mod-manager-v1-rc-redist
Aug 12, 2026
Merged

fix(build): support VS 2026 CRT layout#83
dh0er merged 1 commit into
mainfrom
codex/mod-manager-v1-rc-redist

Conversation

@dh0er

@dh0er dh0er commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • discover the single app-local MSVC CRT family inside the exact CMake-selected Visual Studio redist version
  • support both Visual Studio 2022 VC143 and Visual Studio 2026 VC145 layouts
  • fail closed before signing when the CRT family is missing or ambiguous

Verification

  • python -m unittest scripts.test_build_runtime -v (9/9)
  • python -m unittest discover -s scripts -p test_*.py (50/50)
  • python scripts/check_release_workflow.py
  • git diff --check

Fixes the non-publishing Mod Manager RC smoke-build failure in Actions run 31631888357. All quality gates in that run were green; packaging failed before verification/upload because the VS 2026 runner no longer uses the hard-coded Microsoft.VC143.CRT leaf.


Note

Medium Risk
Changes release packaging for gore-mod-manager only, but failures are fail-closed before signing and the behavior is heavily unit-tested; wrong CRT selection would break portable/installer builds on CI.

Overview
Fixes Mod Manager Windows packaging on Visual Studio 2026 runners, where the app-local MSVC runtime path is no longer a fixed Microsoft.VC143.CRT leaf.

build.py adds _msvc_crt_dir to scan the x64 redist directory for exactly one real Microsoft.VC*.CRT directory (skipping symlinks/junctions), then uses that folder when staging msvcp140 / vcruntime140 DLLs. Resolution is tightened so the chosen CRT directory must stay under its redist x64 folder.

scripts/test_build_runtime.py parametrizes the fake VS layout (toolset, redist version, CRT family), adds a VC145 staging test, and asserts missing or duplicate CRT families raise before sign_paths runs and leave the bundle unchanged.

Reviewed by Cursor Bugbot for commit 08f2a37. Bugbot is set up for automated code reviews on this repo. Configure here.

Visual Studio 2026 names its app-local runtime VC145 while the release packager assumed VC143. Discover the sole CRT family inside the exact selected redist version and fail closed on missing or ambiguous layouts.
@dh0er

dh0er commented Aug 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Fresh review requested on unchanged head 08f2a37 after the prior reviewer window returned no Codex signal. Trigger: 2026-08-12T20:26:24.8998577Z

@dh0er

dh0er commented Aug 12, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 08f2a37e64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 08f2a37. Configure here.

@dh0er

dh0er commented Aug 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@dh0er

dh0er commented Aug 12, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 08f2a37e64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 08f2a37. Configure here.

@dh0er
dh0er merged commit 86668cd into main Aug 12, 2026
2 checks passed
@dh0er
dh0er deleted the codex/mod-manager-v1-rc-redist branch August 12, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant