Big overhaul with configurable chamber count & 'revolver' mode#17
Open
dgw wants to merge 2 commits into
Open
Conversation
As it says in the summary: * Added chamber count as a config setting * Added a 'revolver' mode that picks a cylinder slot and advances it (saved per channel) Other housekeeping: * Added docstrings for helper functions * Expanded on the README a little * Added type annotations (unchecked with mypy, though)
I'm not positive that I like the `sleep()` pause here, but it was MUCH too slow when applied to *all* games. Only doing it when the revolver has to be reloaded might be OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says in the summary:
Other housekeeping:
This replaces #11