docs(upgrade): FilingHomepage soup deprecation, Filing.html() None, httpx2 out of 6.0 - #1392
Merged
Merged
Conversation
…ttpx2 out of 6.0 The 5.60.0 guide pass (bead edgartools-07lk.10, 2026-09-30 decisions). - New section: FilingHomepage(soup=...) and a BeautifulSoup passed as `root` to FilingHomepage / Attachments.load have warned "removed in v6.0" since 5.53.0 (4e31aed) with no guide entry. The replay of the new upgrade-guide gate (#1388) found it. Both warnings and the warning-free parse_homepage_html form verified by running them. - Errors section: filing.html() keeps returning None in 6.0 when there is no HTML primary document. #1338 (5.59.0) made the no-primary-document case return None instead of raising AttributeError; the guide now says that is the decided 6.0 behaviour rather than leaving it to omission. - Still to come: httpx -> httpx2 is out of 6.0 (decided 2026-09-30), not "under consideration". - The top-of-page note claimed only two changes rename or move anything; settings, date helpers, access modes and FilingHomepage(soup=) made it false. Rewritten as loud (warns, then breaks) vs quiet (different values). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This is the 5.60.0 pass on
docs/upgrade/6.0.md, following the 2026-09-30 6.0 decisions.FilingHomepagetakes an lxml tree, not BeautifulSoup.FilingHomepage(soup=...)and aBeautifulSouppassed asroottoFilingHomepageorAttachments.loadhave warned "removed in v6.0" since 5.53.0, with no guide entry. The replay of the new upgrade-guide gate (ci: fail a PR that stages a 6.0 change without updating the upgrade guide (07lk.14) #1388) found the gap. The section covers before/after code, theparse_homepage_htmlbytes-over-str note, and whyfiling.homepageusers are unaffected.filing.html()keeps returningNonein 6.0 when the filing has no HTML primary document. fix(filings): Filing.html() returns None instead of raising when the homepage has no primary document #1338 (5.59.0) made the no-primary-document case returnNoneinstead of raisingAttributeError, and the guide now records that as the decided behaviour.httpx→httpx2is not in 6.0 (decided 2026-09-30). Previously the row said "under consideration".soup=sections had made false. It's rewritten as loud changes (warn, then break) vs quiet ones (different values).Verification
I verified every behavioural claim by running it:
FilingHomepage(url, soup=BeautifulSoup(...))emits both deprecation warnings.FilingHomepage(url, parse_homepage_html(html))emits none, with warnings set to error.FilingHomepage.load(and thereforefiling.homepage) goes throughparse_homepage_html.rootis the second positional parameter.The three regression files that read this guide pass (179).
🤖 Generated with Claude Code