Skip to content

test(bdc): count regex compilations on Python 3.10 too #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgunning merged 1 commit into from
Sep 28, 2026
Merged

test(bdc): count regex compilations on Python 3.10 too #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/issues/regression/test_issue_1342.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
1.1 s, every parsed field identical.

The identifier below is one of BXSL's own rows, in that 10-Q and in its FY2025
10-K (0001736035-26-000004). Counted at `re._compiler.compile`, which every
compilation passes through; the public `re.compile` count misses the ones the
module-level `re.search`/`re.match` make. Offline: `member_candidates=()`
10-K (0001736035-26-000004). Counted at `re._compiler.compile` (`sre_compile.compile`
on 3.10), which every compilation passes through; the public `re.compile` count
misses the ones the module-level `re.search`/`re.match` make. Offline: `member_candidates=()`
needs no filing.
"""

Expand All @@ -28,13 +28,17 @@
@pytest.fixture
def compilations(monkeypatch):
counted = []
real = re._compiler.compile
# `re._compiler` is 3.11+; on 3.10 `re` calls `sre_compile.compile` through the module.
compiler = getattr(re, '_compiler', None)
if compiler is None:
import sre_compile as compiler
real = compiler.compile

def counting(*args, **kwargs):
counted.append(args[0])
return real(*args, **kwargs)

monkeypatch.setattr(re._compiler, 'compile', counting)
monkeypatch.setattr(compiler, 'compile', counting)
return counted


Expand Down
Loading