Fix simple generator execution for parameterized methods#80
Closed
Copilot wants to merge 3 commits intobugfix/simple_method_with_parameterfrom
Closed
Fix simple generator execution for parameterized methods#80Copilot wants to merge 3 commits intobugfix/simple_method_with_parameterfrom
Copilot wants to merge 3 commits intobugfix/simple_method_with_parameterfrom
Conversation
Co-authored-by: dex3r <3155725+dex3r@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: dex3r <3155725+dex3r@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix generator method parameter count mismatch
Fix simple generator execution for parameterized methods
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple-pattern generator methods with parameters were failing at generation time with
TargetParameterCountException(MSGH004). The runtime invocation path only handled zero args or a single converted arg, which broke methods likeSimpleMethodWithParameter_Generator(int).Runtime invocation: robust parameter binding
GeneratesMethodExecutionRuntime.ConvertArguments(...)to bind all method parameters instead of only the first.args.Length > parameters.Length).0forint,nullfor reference/nullable types), allowing simple-pattern generators with parameters to execute.Regression coverage in generator runtime tests
GeneratesMethodExecutionRuntimeTeststo assert simple generator methods with parameters execute successfully using defaulted inputs.Issue test expectation alignment
SimpleMethodWithParametergenerated-code expectation to match the actual partial signature (intreturn type +int someIntParameter) rather than a parameterless/string signature.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.