Fix popover closing instantly on macOS 27

[devxoul]

Summary

Fixes #96. On macOS 27, the popover flashes open and closes immediately, which reads as "the app doesn't launch at all" since Allkdic is an LSUIElement app with no Dock icon and no window.

Root Cause

AppDelegate.setupEventMonitor() installs a global mouse monitor matching [.leftMouseUp, .leftMouseDown] that calls closePopover(). Global monitors are documented as not receiving events routed to your own app, but on macOS 27 the .leftMouseUp of the very click that opens the popover is delivered to this monitor anyway. The sequence becomes: status item click -> openPopover() -> .leftMouseUp -> global monitor -> closePopover().

@mirinae312 diagnosed this on #96 with a diagnostic build (log + call stack) and confirmed with an A/B test that excluding .leftMouseUp keeps the popover open on macOS 27. Thanks for narrowing this down!

Fix

Narrow the monitor mask to .leftMouseDown only.

- NSEvent.addGlobalMonitorForEvents(matching: [.leftMouseUp, .leftMouseDown]) { [weak self] _ in
+ NSEvent.addGlobalMonitorForEvents(matching: .leftMouseDown) { [weak self] _ in
    self?.closePopover()
  }

Outside-click dismissal is unchanged: a press outside the popover already triggers closePopover() before its release ever arrives, so .leftMouseUp was redundant for dismissal. closePopover() also guards on popover.isShown, so a stray mouse-down before the popover is shown is a no-op.

Alternative considered

Removing the global monitor entirely and relying on popover.behavior = .transient, which by documentation closes the popover on outside interaction. Rejected for now: the monitor has been in place since 2014 as the safety net for clicks in other apps, and removing it risks a "popover stays open" regression on some macOS version nobody here can currently test. Narrowing the mask is the smaller, evidence-backed change.

Testing

• xcodebuild build — build succeeds (code signing disabled locally; no Mac Development cert on this machine)
• xcodebuild test — 45 tests, 0 failures (KeyBindingTests 25, PopupRequestTests 20)
• make lint — the changed file passes; the only lint error is pre-existing in the Tuist-generated TuistBundle+Allkdic.swift, untouched here
• Not verified on macOS 27. This machine runs macOS 26.5.2, so the fix could not be reproduced or confirmed locally — it relies on @mirinae312's diagnostic build and A/B test on macOS 27골든 게이트 업데이트 이후로 작동을 하지 않는 것 같습니다 ㅠㅠ #96. Please confirm on macOS 27 before release.
• Manual regression on macOS 26 (outside click, app switch, Escape, re-clicking the icon, clicking another status item) is still worth doing before release.

No automated regression test was added: the monitor is installed inside AppDelegate at launch, and the existing test target only covers pure-logic types — asserting on an NSEvent.EventTypeMask constant would be a tautology.

Fixes #96

---

Summary by cubic

Fixes the Allkdic popover closing instantly on macOS 27, which made the app seem to never launch (it has no Dock icon or window).

The global mouse monitor listened for both .leftMouseUp and .leftMouseDown and called closePopover(). On macOS 27, the .leftMouseUp of the click that opens the popover also reaches this monitor, so the popover closed right after appearing (#96). Narrowing the monitor to .leftMouseDown only keeps outside-click dismissal working, because a press outside already closes the popover before its release arrives.

Testing

• Build and all 45 tests pass; make lint only reports a pre-existing error in the Tuist-generated TuistBundle+Allkdic.swift, untouched here.
• Not verified on macOS 27 — the fix relies on a diagnostic build and A/B test from macOS 27골든 게이트 업데이트 이후로 작동을 하지 않는 것 같습니다 ㅠㅠ #96, so confirm on macOS 27 before release. Manual regression on macOS 26 is still recommended.

^{Written for commit dea5355. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}

[typeey]

The mask reduction is correctly scoped: outside left-clicks still call closePopover() on mouse-down, while issue #96 records a macOS 27 A/B test confirming that excluding the opening mouse-up prevents the failure. Head CI passes lint, build, and all tests; although those tests cannot exercise OS event routing, the targeted manual evidence and narrow regression surface support approval.