fix(react-router-example): use process.env for DATABASE_URL fallback - #41
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
kattsushi
added a commit
that referenced
this pull request
Mar 15, 2026
…41) * fix(react-router-example): use process.env for DATABASE_URL fallback * refactor: remove unused import from prisma config file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
env("DATABASE_URL")withprocess.env.DATABASE_URLinprisma.config.ts.Reason:
env()fromprisma/configthrows an error if the environment variable is missing, which causes CI/CD failures duringprisma generatewhen no DB is available.Using
process.envallows the nullish coalescing operator (??) to provide a fallback dummy URL, enabling the generation step to succeed in CI.Summary by CodeRabbit