Skip to content

fix(release): suppress reviewed beta merges - #271

Merged
kattsushi merged 1 commit into
masterfrom
fix/beta-suppress-reviewed-release
Aug 31, 2026
Merged

kattsushi merged 1 commit into
masterfrom
fix/beta-suppress-reviewed-release

Conversation

@kattsushi

Copy link
Copy Markdown
Contributor

Closes #268

Summary

  • Restore safe suppression for an exact reviewed beta release merge even when its generated merge subject contains chore(release): or [skip release].
  • Keep release-subject pushes fail-closed for every benign, source, partial, mixed, or malformed non-exact shape.
  • Add extracted-workflow-shell regressions for the real merge subject and classifier ordering.

Incident

Beta release PR #270 merged as exact reviewed artifact commit 208546a031ddbd083c00564b96628a4ef65763e7, but push run https://github.com/devx-op/effectify/actions/runs/33352581754 rejected it before suppression because subject heuristics ran before the stronger structural classifier. No tags, GitHub Releases, or npm packages were created.

Changes

File Change
.github/workflows/cd.yml Evaluate exact structural suppression before release-subject rejection.
scripts/release-policy-contract.test.mjs Execute exact/non-exact subject cases and reject a subject-first ordering mutation.

Test Plan

  • Release policy contract: 29/29 tests passed.
  • Exact generated release subject suppresses under extracted Bash.
  • Non-exact release subjects still reject.
  • Workflow YAML, syntax, formatting, and whitespace checks passed.

Contributor Checklist

@kattsushi kattsushi added the type:bug Bug fix label Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 41 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 408b7b03-a06b-49cd-bcf4-06b2f07b8289

📥 Commits

Reviewing files that changed from the base of the PR and between 208546a and f3dfeb8.

📒 Files selected for processing (2)
  • .github/workflows/cd.yml
  • scripts/release-policy-contract.test.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kattsushi
kattsushi merged commit 6fcbc01 into master Aug 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: complete Effect v4 cleanup and restore stable releases

1 participant