fix(release): preserve PATH in stable suppression - #262
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release workflow now uses ChangesStable suppression PATH fix
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This fix preserves executable lookup during stable suppression while retaining the existing classification and suppression behavior. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The workflow now uses MANIFEST_PATH for stable suppression records and references. The contract updates reject PATH shadowing and protect manifest metadata and mutation behavior. The changes align with issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #261
Type
Summary
Preserve executable lookup while classifying the exact seven-package stable merge in the beta workflow. Rename the stable-suppression record field from reserved shell
PATHtoMANIFEST_PATHand lock it with mutation-resistant contracts.Root cause
Post-stable-merge beta run 33271234826 failed before publication because the resolver used:
That replaced shell executable lookup before invoking
gitandjq. Every beta build/test/PREPARE/auth/FINALIZE step was skipped; no artifact was published.Changes
MANIFEST_PATH.MANIFEST_PATH.PATHloop bindings and an exact regression mutation.Verification
Safety
Summary by CodeRabbit