fix(release): pin exact stable targets - #258
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughPREPARE now versions each stable package with its explicit target version. Contract tests enforce the seven-package matrix and command shape. Regression tests cover collisions, delegated calculations, changelog idempotence, and dry-run behavior. ChangesStable release target versioning
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change makes stable package releases use explicitly authorized versions while preserving validation and protected commit and push behavior. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #257
Type
Summary
Version each protected stable package through Nx with its exact authorized target instead of applying one history-dependent global
patchspecifier.Root cause
Run 33264803174 proved Nx resolves relative bumps per package from historical stable tags when available:
0.5.10and calculated0.5.11, not authorized0.6.0.0.5.11and calculated already-published0.5.12, not authorized0.5.13.The run failed before branch creation and published nothing.
Changes
NAME|MANIFEST_PATH|OLD|NEWrecords sequentially.pnpm nx release version "$NEW" "--projects=$NAME"once per package.patchform, global project selection, direct manifest editing, wrong/missing/duplicate records, and weakened ordering.0.5.10, stale Solid0.5.12, exact target collision, no delegation after failure, cumulative seven-entry changelog idempotency, and dry-run no-write behavior.Verification
git diff --checkpassed.Safety
Summary by CodeRabbit
Bug Fixes
Tests