Skip to content

fix(solid-query): update dependencies and classify as peerDependencies - #21

Merged
kattsushi merged 3 commits into
masterfrom
fix/solid-query-deps
Feb 6, 2026
Merged

kattsushi merged 3 commits into
masterfrom
fix/solid-query-deps

Conversation

@kattsushi

Copy link
Copy Markdown
Contributor

Updates dependencies for @effectify/solid-query and moves effect, solid-js, and tanstack query packages to peerDependencies to avoid version conflicts in consuming applications. Also updates pnpm-workspace.yaml versions.

@nx-cloud

nx-cloud Bot commented Feb 6, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 3082dbe

Command Status Duration Result
nx affected --target=test --base=87c40a1ce45893... ✅ Succeeded 9s View ↗
nx affected --target=typecheck --base=origin/ma... ✅ Succeeded 11s View ↗
nx affected --target=build --base=87c40a1ce4589... ✅ Succeeded 7s View ↗
nx affected --target=lint --base=origin/master ... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-06 20:01:08 UTC

@nx-cloud nx-cloud Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

These changes update @tanstack/react-query from 5.90.10 to 5.90.20 to match the @tanstack/query-core version that was bumped in the original PR. This resolves the TypeScript compilation error in @effectify/react-query where incompatible QueryClient types from different @tanstack/query-core versions were causing build failures.

Warning

❌ We could not verify this fix.

Suggested Fix changes
diff --git a/nx.json b/nx.json
index ee53bd7..25440dc 100644
--- a/nx.json
+++ b/nx.json
@@ -5,10 +5,7 @@
     "packageManager": "pnpm"
   },
   "namedInputs": {
-    "default": [
-      "{projectRoot}/**/*",
-      "sharedGlobals"
-    ],
+    "default": ["{projectRoot}/**/*", "sharedGlobals"],
     "production": [
       "default",
       "!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
@@ -35,10 +32,7 @@
     },
     {
       "plugin": "@nx/vite/plugin",
-      "exclude": [
-        "apps/solid-app-start/**/*",
-        "apps/react-app-remix/**/*"
-      ],
+      "exclude": ["apps/solid-app-start/**/*", "apps/react-app-remix/**/*"],
       "options": {
         "buildTargetName": "build",
         "testTargetName": "test",
@@ -100,9 +94,7 @@
     }
   },
   "sync": {
-    "disabledTaskSyncGenerators": [
-      "@nx/js:typescript-sync"
-    ]
+    "disabledTaskSyncGenerators": ["@nx/js:typescript-sync"]
   },
   "targets": {
     "local-registry": {
@@ -138,45 +130,26 @@
   "targetDefaults": {
     "dev": {
       "cache": false,
-      "dependsOn": [
-        "^build"
-      ]
+      "dependsOn": ["^build"]
     },
     "build": {
       "cache": true,
-      "inputs": [
-        "production",
-        "^production"
-      ],
-      "dependsOn": [
-        "^build"
-      ]
+      "inputs": ["production", "^production"],
+      "dependsOn": ["^build"]
     },
     "serve": {
       "cache": false,
-      "dependsOn": [
-        "^build"
-      ]
+      "dependsOn": ["^build"]
     },
     "@nx/esbuild:esbuild": {
       "cache": true,
-      "dependsOn": [
-        "^build"
-      ],
-      "inputs": [
-        "production",
-        "^production"
-      ]
+      "dependsOn": ["^build"],
+      "inputs": ["production", "^production"]
     },
     "@nx/js:tsc": {
       "cache": true,
-      "dependsOn": [
-        "^build"
-      ],
-      "inputs": [
-        "production",
-        "^production"
-      ]
+      "dependsOn": ["^build"],
+      "inputs": ["production", "^production"]
     }
   },
   "generators": {
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index 682fd4a..1c836f6 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -54,7 +54,7 @@ catalog:
   "@tailwindcss/vite": 4.1.17
   "@tanstack/query-core": 5.90.20
   "@tanstack/react-form": 1.25.0
-  "@tanstack/react-query": 5.90.10
+  "@tanstack/react-query": 5.90.20
   "@tanstack/react-query-devtools": 5.91.0
   "@tanstack/react-router": 1.139.3
   "@tanstack/react-router-devtools": 1.139.3

Apply fix via Nx Cloud  Reject fix via Nx Cloud


Or Apply changes locally with:

npx nx-cloud apply-locally swjB-uaFZ

Apply fix locally with your editor ↗   View interactive diff ↗


🎓 Learn more about Self-Healing CI on nx.dev

@kattsushi
kattsushi merged commit 3d315af into master Feb 6, 2026
6 checks passed
kattsushi added a commit that referenced this pull request Mar 15, 2026
#21)

* fix(solid-query): update dependencies and classify as peerDependencies

* fix(solid-query): revert core version in workspace, fix solid-query deps explicitly

* fix(solid-query): update workspace versions but pin react-query to old versions to avoid build breakage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant