Repository navigation
chore: add a listing icon and credential notes to the plugin - #32
Merged
Merged
Conversation
The Anthropic plugin directory takes the listing icon from .claude-plugin/icon.png only when a plugin is first submitted, so the icon goes in before the submission. It is the site's logo at 1024 px. The directory holds a skill for review when a credential-named variable appears beside a remote URL. The README now lists each credential the gateway uses and the only party it is sent to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
plugins/agent-commerce-gateway/.claude-plugin/icon.png: a 1024 x 1024 PNG (37 KB) of the logo from acg.devlab.group (favicon.svg).plugins/agent-commerce-gateway/README.md: a "Credentials the gateway uses" table, and a note that the default facilitator needs no credentials.tests/unit/cli/skill.test.ts: checks that the icon exists.Why
The developer portal's Validate step on
plugins/agent-commerce-gateway(master @ 3d016ba) reported:.claude-plugin/icon.pngonly the first time a plugin is saved or submitted, and adding it later does not change the listing. It has to be in the repository before the submission.${VAR}in the same file as a remote URL:GATEWAY_SHARED_SECRETbesidex402.org,ADMIN_TOKENbeside the Base Sepolia RPC URL,BACKEND_TOKENbesidegithub.comlinks. None of these values goes to those hosts. The portal's options are a${user_config.KEY}value, which applies to MCP servers and hooks rather than a config the skill writes, or leaving it for a reviewer to confirm. This PR keeps the skill as it is and gives the reviewer the table in the README: each variable and the only party it is sent to.documentationUrlandsupportUrl: the portal says "No action needed", since the directory reads them for the listing.How it was tested
npx vitest run tests/unit/cli/skill.test.ts: 10 passed.npx biome check .: clean.node scripts/check-package-metadata.mjs: OK.claude plugin validate ./plugins/agent-commerce-gateway: passes; the only warnings aredocumentationUrlandsupportUrl, as before.npx vitest run: 3504 passed, 3 failed, 6 skipped. The 3 failures are the same macOS-only ones as on master (bash 3.2 withoutmapfilein the twogateway-entrypointtests, and theadapters413 test).Not covered