Repository navigation
feat: prepare the Claude plugin for the plugin directory - #11
Uzair-Ahmed-Dahraj merged 2 commits into
Conversation
There was a problem hiding this comment.
devkind-code-review: devkindhq/whatweb-mcp #11
Mode: comment-only · Head: d9beccde
Checks (at head, fresh tarball): all three JSON manifests parse clean (plugin.json, marketplace.json, .mcp.json) · icon is a real 512×512 PNG (55 KB) and the referenced path exists · no stale 1.1.0 references left in .claude-plugin/.
Verified
- README "Network access and data" claims spot-checked against source:
MAX_RESULTS = 100(server.py:78) ✓ · WhatWeb pinned atv0.6.4in the Dockerfile clone ✓ · logging vialogging.basicConfig→ stderr ✓ · no telemetry/external-call code inserver.py(only outbound traffic is the scan target itself and Docker Hub image pulls) ✓. This section is what the directory's security scan reads — good that it's explicit. .mcp.jsonnow wrapped inmcpServersmatching the documented shape; command unchanged.marketplace.jsonmirrors the machship-mcp/starshipit-mcp pattern — consistent with the siblings.- Review Notes are honest and correct: the dropped
:1.0.1image pin was the right call (it would have forced a PR on every release), andlatestis the documented exception to the directory's launcher-pin rule fordocker.
Findings
low — plugin version now drifts from server.json (1.1.1 vs 1.0.1)
With plugin.json at 1.1.1 and server.json at 1.0.1, the two version surfaces disagree — the same tag/version reconciliation issue tracked on this repo's siblings (carried escalation since Nov 2: no git tag exists yet at all). Not a merge blocker for a metadata PR, but when you cut the v1.0.1 release for #10, consider bumping server.json + plugin.json together and tagging v1.1.1 so the plugin directory listing, MCP registry, and Docker Hub all agree. The registry entry (io.github.devkindhq/whatweb-mcp) still advertises 1.0.1.
note — merge order dependency is documented but soft
"Submit to the directory only after #10 merges" lives only in the PR body. If this merges first and someone submits before the release, directory users install a plugin whose latest image still carries the 5 high-severity mcp advisories. A one-line note in the README's plugin section ("requires image ≥ 1.0.1") would make the constraint survive past this PR.
Verdict: green — clean metadata PR, claims verified against source. Merge order note above is the only thing worth acting on.
There was a problem hiding this comment.
devkind-code-review: devkindhq/whatweb-mcp #11
Mode: comment-only | Head: verified against live docs
Plugin-directory prep reviewed. Verified specifics:
.mcp.jsonmcpServerswrapper: checked against the current Claude Code plugin docs + the maintainer's ruling on anthropics/claude-code#63694 — both the wrapped and flat formats are accepted in a plugin's.mcp.json, so this change is safe (the flat form is merely what official plugins happen to use).plugin.json:icon: "./assets/icon.png"matches the directory-listing field spec (./-prefixed path inside the plugin root);displayNameis a valid manifest field. Good.- README: the added "Network access and data" section covers exactly what the directory submission asks plugins to disclose (outbound requests, user agent, redirect following, telemetry-free, log retention via
--rm). Nice.
No findings. ✅ — cron audit Nov 7 2026
|
post-merge verify-fixes audit (merged 2026-11-09T04:53Z, reviewed at merge-commit state) Findings from the two bot reviews, re-verified at the merged tree:
Context: #10 (the mcp bump) merged ~1h before this one, so the merge-order hazard the note was guarding against is now moot for the initial submission — the remaining value is for anyone installing |
Problem
The repo root is a Claude Code plugin, but it is not ready for the Claude plugin directory:
plugin.jsonhas nodisplayNameand noicon.claude plugin validatewarnsNo icon (ICON_MISSING)..mcp.jsonlists the server without themcpServerskey that the plugin docs show.Fix
plugin.json: adddisplayName("WhatWeb MCP") andicon(./assets/icon.png, the 512×512 Devkind icon that machship-mcp and starshipit-mcp use). Raiseversionto 1.1.1..mcp.json: wrap the entry inmcpServers. The command is unchanged and still runsdevkind/whatweb-mcp:latest..claude-plugin/marketplace.json: new file, the same as in machship-mcp and starshipit-mcp./plugin install whatweb --marketplace devkindhq/whatweb-mcpnow works.--rm). The "Claude Code skill" section becomes "Claude Code plugin", with the install command. The manual skill copy stays.Example
claude plugin validate .:⚠ Found 1 plugin directory warning: ... No icon (ICON_MISSING), plus the adviceThis README has no line that installs "whatweb" from a marketplace.✔ Validation passed, with no directory warnings.Verification
claude plugin validate .(Claude Code 2.1.318):✔ Validation passed.claude plugin marketplace addon this branch, thenclaude plugin install whatweb@whatweb-mcp:Successfully installed plugin: whatweb@whatweb-mcp, version 1.1.1.claude mcp listshows the server asplugin:whatweb:whatweb.server.py, the Dockerfile and the WhatWeb v0.6.4 source:WhatWeb/#{WhatWeb::VERSION}(lib/whatweb.rb:68);$FOLLOW_REDIRECT = 'always'(lib/whatweb.rb:70) andmax_redirects = 10;MAX_RESULTS = 100and logging to stderr inserver.py;docker rundefaults to--pull missing.Review Notes
devkind/whatweb-mcp:latest, so installs still get new images throughdocker pull. The directory's pin rule covers package launchers such asnpxanduvx, notdocker.v1.0.1release moveslatestoff1.0.0.1.0.0still has the high-severitymcpadvisories that fix: bump mcp to 1.28.1 and fix read_resource #10 fixes..mcp.jsonhad nomcpServerskey. Claude Code accepted the flat form, but the docs show the wrapped form. Fixed.1.0.1. That pin forced a fixed merge order and a second PR on every release, and it changed how existing installs get updates. It was dropped.server.pymapspoliteto-a 2, but WhatWeb v0.6.4 accepts only levels 1, 3 and 4:Agression level must be 1,3, or 4. 2 is invalid.(whatwebline 505). Everypolitescan fails today.