Skip to content

feat: prepare the Claude plugin for the plugin directory - #11

Merged
Uzair-Ahmed-Dahraj merged 2 commits into
devkindhq:mainfrom
Uzair-Ahmed-Dahraj:feat/plugin-directory-listing
Nov 9, 2026
Merged

Uzair-Ahmed-Dahraj merged 2 commits into
devkindhq:mainfrom
Uzair-Ahmed-Dahraj:feat/plugin-directory-listing

Conversation

@Uzair-Ahmed-Dahraj

@Uzair-Ahmed-Dahraj Uzair-Ahmed-Dahraj commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The repo root is a Claude Code plugin, but it is not ready for the Claude plugin directory:

  • plugin.json has no displayName and no icon. claude plugin validate warns No icon (ICON_MISSING).
  • .mcp.json lists the server without the mcpServers key that the plugin docs show.
  • The README does not say what the plugin downloads, which hosts it calls or what it stores. The directory's security scan compares the README with what the plugin does.
  • No marketplace file exists, so users cannot install the plugin from this repo in one step.

Fix

  • plugin.json: add displayName ("WhatWeb MCP") and icon (./assets/icon.png, the 512×512 Devkind icon that machship-mcp and starshipit-mcp use). Raise version to 1.1.1.
  • .mcp.json: wrap the entry in mcpServers. The command is unchanged and still runs devkind/whatweb-mcp:latest.
  • .claude-plugin/marketplace.json: new file, the same as in machship-mcp and starshipit-mcp. /plugin install whatweb --marketplace devkindhq/whatweb-mcp now works.
  • README: new "Network access and data" section (Docker Hub pull, requests to the target, redirects, tool result, no telemetry, in-memory results, --rm). The "Claude Code skill" section becomes "Claude Code plugin", with the install command. The manual skill copy stays.

Example

claude plugin validate .:

  • Before: ⚠ Found 1 plugin directory warning: ... No icon (ICON_MISSING), plus the advice This README has no line that installs "whatweb" from a marketplace.
  • After: ✔ Validation passed, with no directory warnings.

Verification

  • claude plugin validate . (Claude Code 2.1.318): ✔ Validation passed.
  • With an empty config dir, claude plugin marketplace add on this branch, then claude plugin install whatweb@whatweb-mcp: Successfully installed plugin: whatweb@whatweb-mcp, version 1.1.1. claude mcp list shows the server as plugin:whatweb:whatweb.
  • Each README claim was checked against server.py, the Dockerfile and the WhatWeb v0.6.4 source:
    • user agent WhatWeb/#{WhatWeb::VERSION} (lib/whatweb.rb:68);
    • $FOLLOW_REDIRECT = 'always' (lib/whatweb.rb:70) and max_redirects = 10;
    • MAX_RESULTS = 100 and logging to stderr in server.py;
    • docker run defaults to --pull missing.

Review Notes

  • Image tag. The plugin keeps devkind/whatweb-mcp:latest, so installs still get new images through docker pull. The directory's pin rule covers package launchers such as npx and uvx, not docker.
  • Merge order. This PR can merge on its own. Submit to the directory only after fix: bump mcp to 1.28.1 and fix read_resource #10 merges and a v1.0.1 release moves latest off 1.0.0. 1.0.0 still has the high-severity mcp advisories that fix: bump mcp to 1.28.1 and fix read_resource #10 fixes.
  • Review findings:
    • Review found that .mcp.json had no mcpServers key. Claude Code accepted the flat form, but the docs show the wrapped form. Fixed.
    • An earlier version of this PR pinned the image to 1.0.1. That pin forced a fixed merge order and a second PR on every release, and it changed how existing installs get updates. It was dropped.
  • Separate defect, not in this PR: server.py maps polite to -a 2, but WhatWeb v0.6.4 accepts only levels 1, 3 and 4: Agression level must be 1,3, or 4. 2 is invalid. (whatweb line 505). Every polite scan fails today.

@Uzair-Ahmed-Dahraj
Uzair-Ahmed-Dahraj marked this pull request as ready for review November 5, 2026 04:24

@superkindhq superkindhq Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devkind-code-review: devkindhq/whatweb-mcp #11

Mode: comment-only · Head: d9beccde

Checks (at head, fresh tarball): all three JSON manifests parse clean (plugin.json, marketplace.json, .mcp.json) · icon is a real 512×512 PNG (55 KB) and the referenced path exists · no stale 1.1.0 references left in .claude-plugin/.

Verified

  • README "Network access and data" claims spot-checked against source: MAX_RESULTS = 100 (server.py:78) ✓ · WhatWeb pinned at v0.6.4 in the Dockerfile clone ✓ · logging via logging.basicConfig → stderr ✓ · no telemetry/external-call code in server.py (only outbound traffic is the scan target itself and Docker Hub image pulls) ✓. This section is what the directory's security scan reads — good that it's explicit.
  • .mcp.json now wrapped in mcpServers matching the documented shape; command unchanged.
  • marketplace.json mirrors the machship-mcp/starshipit-mcp pattern — consistent with the siblings.
  • Review Notes are honest and correct: the dropped :1.0.1 image pin was the right call (it would have forced a PR on every release), and latest is the documented exception to the directory's launcher-pin rule for docker.

Findings

low — plugin version now drifts from server.json (1.1.1 vs 1.0.1)

With plugin.json at 1.1.1 and server.json at 1.0.1, the two version surfaces disagree — the same tag/version reconciliation issue tracked on this repo's siblings (carried escalation since Nov 2: no git tag exists yet at all). Not a merge blocker for a metadata PR, but when you cut the v1.0.1 release for #10, consider bumping server.json + plugin.json together and tagging v1.1.1 so the plugin directory listing, MCP registry, and Docker Hub all agree. The registry entry (io.github.devkindhq/whatweb-mcp) still advertises 1.0.1.

note — merge order dependency is documented but soft

"Submit to the directory only after #10 merges" lives only in the PR body. If this merges first and someone submits before the release, directory users install a plugin whose latest image still carries the 5 high-severity mcp advisories. A one-line note in the README's plugin section ("requires image ≥ 1.0.1") would make the constraint survive past this PR.

Verdict: green — clean metadata PR, claims verified against source. Merge order note above is the only thing worth acting on.

@superkindhq superkindhq Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devkind-code-review: devkindhq/whatweb-mcp #11

Mode: comment-only | Head: verified against live docs

Plugin-directory prep reviewed. Verified specifics:

  • .mcp.json mcpServers wrapper: checked against the current Claude Code plugin docs + the maintainer's ruling on anthropics/claude-code#63694 — both the wrapped and flat formats are accepted in a plugin's .mcp.json, so this change is safe (the flat form is merely what official plugins happen to use).
  • plugin.json: icon: "./assets/icon.png" matches the directory-listing field spec (./-prefixed path inside the plugin root); displayName is a valid manifest field. Good.
  • README: the added "Network access and data" section covers exactly what the directory submission asks plugins to disclose (outbound requests, user agent, redirect following, telemetry-free, log retention via --rm). Nice.

No findings. ✅ — cron audit Nov 7 2026

@Uzair-Ahmed-Dahraj
Uzair-Ahmed-Dahraj merged commit ffa64b5 into devkindhq:main Nov 9, 2026
1 check passed
@superkindhq

superkindhq Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

post-merge verify-fixes audit (merged 2026-11-09T04:53Z, reviewed at merge-commit state)

Findings from the two bot reviews, re-verified at the merged tree:

Finding Verdict Evidence
low — plugin.json 1.1.1 vs server.json 1.0.1 version drift ❌ unchanged (carried, was non-blocking) .claude-plugin/plugin.json 1.1.1 · server.json 1.0.1 · tag cut is v1.0.1
note — README should pin "requires image ≥ 1.0.1" so the directory-submission order constraint survives the PR body ❌ not added no such note in README at merge

Context: #10 (the mcp bump) merged ~1h before this one, so the merge-order hazard the note was guarding against is now moot for the initial submission — the remaining value is for anyone installing latest from an old cache. Both items remain nice-to-haves; nothing blocking shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant