Repository navigation
fix: bump mcp to 1.28.1 and fix read_resource #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uzair-Ahmed-Dahraj
merged 5 commits into
devkindhq:main
from
Uzair-Ahmed-Dahraj:chore/open-source-ready
Nov 9, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
42f195e
feat: prepare 1.1.0 for open source
Uzair-Ahmed-Dahraj de47a4e
chore: keep only the security and bug fixes
Uzair-Ahmed-Dahraj 596f072
fix: bump mcp to 1.28.1 and fix read_resource
Uzair-Ahmed-Dahraj 653830a
docs: drop Smithery from the roadmap
Uzair-Ahmed-Dahraj 4f1dc46
chore: remove smithery.yaml
Uzair-Ahmed-Dahraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| mcp==1.6.0 | ||
| mcp==1.28.1 | ||
| pydantic==2.11.5 | ||
| pydantic-settings==2.9.1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| """Tests for resources/read through the registered MCP handler.""" | ||
|
|
||
| import asyncio | ||
| import json | ||
|
|
||
| from mcp import types | ||
|
|
||
| import server | ||
|
|
||
|
|
||
| def test_read_unknown_result_returns_not_found(): | ||
| handler = server.app.request_handlers[types.ReadResourceRequest] | ||
| req = types.ReadResourceRequest( | ||
| method="resources/read", | ||
| params=types.ReadResourceRequestParams(uri="whatweb://results/missing"), | ||
| ) | ||
| result = asyncio.run(handler(req)) | ||
| text = result.root.contents[0].text | ||
| assert json.loads(text) == {"error": "Resource not found"} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[compat] On Python ≥3.14
mcp==1.28.1requirespydantic>=2.12.0, conflicting with this file'spydantic==2.11.5pin (reproducedResolutionImpossibleon 3.14.7). Fine on 3.12/3.13 — consider a floor bump or README note.