Repository navigation
Prepare Shopify on Cloudflare for open-source submission - #4
Merged
Merged
Conversation
Replace the incompatible v3 authenticatedFetch utility (which calls app.subscribe(), absent on the v4 useAppBridge() global) with a typed createAuthenticatedFetch helper that attaches the App Bridge 4 ID token as a Bearer header. Drop the @shopify/app-bridge v3 dependency, add a regression test, allow devDependency imports in test files, and add Devkind author metadata.
A static, credential-free page at GET /preview so a visitor with no Shopify session (e.g. a Cloudflare Templates reviewer) can see what the template is. Emphasises the embedded-app model and shows the stack, request flow, and a live edge-status strip. Outside /api/*, so requireShop never runs against it. Includes unit + Playwright coverage.
Fix the documented OAuth routes to match the code (/shopify/install and /shopify/callback) and add the deployed public preview URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare the Shopify on Cloudflare starter for open-source publication and its Cloudflare Templates submission.
Changes
/previewpage that works without Shopify authentication/api/exampleprotectedmainVerification
npm cinpm run lint:cinpm run test:coverage(20 tests passed)npm run type-checknpm run checknpm run test:e2e(4 tests passed)Public preview: https://cloudflare-shopify-starter-template.ali-d43.workers.dev/preview