Repository navigation
fix(security): bump react-router-dom 6 -> 7.18.2 — clear remaining audit advisories (Ref: #8) - #10
Merged
Merged
Conversation
…/ XSS / constructor injection advisories) React Router advisories affecting <=7.17.0: - GHSA open redirect via backslash in <Link> and useNavigate (CVE-2025-68470 bypass) - GHSA-337j-9hxr-rhxg arbitrary constructor injection via deserializeErrors() in SSR hydration - GHSA open redirect leading to XSS (react-router-dom 6.30.2-6.30.4) Fix is a major version bump (6 -> 7) in library mode. App usage (BrowserRouter, Routes, Route, Link in web/main.tsx, web/App.tsx) is API-compatible across the v6->v7 boundary; no source changes needed. Ref: #8
rome2o
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security audit fixes (2026-08-16)
Ref: #8
Issue #8 findings — already resolved
All 5 findings listed in #8 (
@cloudflare/vite-plugin,brace-expansion,js-yaml,miniflare,nanoid) were cleared onmainby PR #9 (semver-compatible lockfile bumps). Verified before starting:npm auditon currentmainshows 0 high / 0 critical. This PR addresses the remaining actionable advisories so #8 can close with a fully triaged audit state.react-router-dom 6.30.4 → 7.18.2 (major bump, library mode)
Clears 3 moderate advisories:
<Link>/useNavigate(CVE-2025-68470 bypass)deserializeErrors()in SSR hydration (GHSA-337j-9hxr-rhxg)React Router v7 library mode is API-compatible with our usage —
BrowserRouter,Routes,Route,Link(web/main.tsx,web/App.tsx) — on React 18. No source changes required; type-check, tests, lint, and full build (vite build+wrangler deploy --dry-run) all pass unchanged.Audit before / after
Skipped (noted, not fixed):
drizzle-kit/esbuild/@esbuild-kit/*(4 moderate, dev-only chain). npm's only proposed "fix" is a semver-major downgrade of drizzle-kit 0.31.10 → 0.18.1 — not acceptable. esbuild here is drizzle-kit's dev-server dep (not the vite dev server used by the app). Recommend a dedicated drizzle-kit upgrade PR once upstream ships a patched release.Verification
npm run type-check— ✅ passCI=true npx vitest run— ✅ 6 files, 20/20 tests passednpm run lint:ci— ✅ passnpm run check(tsc + vite build + wrangler deploy --dry-run) — ✅ passnpm audit— ✅ 0 high, 0 critical, 4 moderate (all triaged above)