Skip to content

fix(security): bump react-router-dom 6 -> 7.18.2 — clear remaining audit advisories (Ref: #8) - #10

Merged
rome2o merged 1 commit into
mainfrom
fix/security-deps-issue-8
Aug 16, 2026
Merged

rome2o merged 1 commit into
mainfrom
fix/security-deps-issue-8

Conversation

@superkindhq

@superkindhq superkindhq Bot commented Aug 16, 2026

Copy link
Copy Markdown

Security audit fixes (2026-08-16)

Ref: #8

Issue #8 findings — already resolved

All 5 findings listed in #8 (@cloudflare/vite-plugin, brace-expansion, js-yaml, miniflare, nanoid) were cleared on main by PR #9 (semver-compatible lockfile bumps). Verified before starting: npm audit on current main shows 0 high / 0 critical. This PR addresses the remaining actionable advisories so #8 can close with a fully triaged audit state.

react-router-dom 6.30.4 → 7.18.2 (major bump, library mode)

Clears 3 moderate advisories:

Advisory Severity Affected
Open redirect via backslash in <Link> / useNavigate (CVE-2025-68470 bypass) moderate react-router >=6.0.0 <7.18.0
Arbitrary constructor injection via deserializeErrors() in SSR hydration (GHSA-337j-9hxr-rhxg) moderate react-router >=6.4.0 <7.18.0
Open redirect leading to XSS moderate react-router-dom 6.30.2–6.30.4

React Router v7 library mode is API-compatible with our usage — BrowserRouter, Routes, Route, Link (web/main.tsx, web/App.tsx) — on React 18. No source changes required; type-check, tests, lint, and full build (vite build + wrangler deploy --dry-run) all pass unchanged.

Audit before / after

Severity Before After
critical 0 0
high 0 0
moderate 6 4
low 0 0

Skipped (noted, not fixed): drizzle-kit / esbuild / @esbuild-kit/* (4 moderate, dev-only chain). npm's only proposed "fix" is a semver-major downgrade of drizzle-kit 0.31.10 → 0.18.1 — not acceptable. esbuild here is drizzle-kit's dev-server dep (not the vite dev server used by the app). Recommend a dedicated drizzle-kit upgrade PR once upstream ships a patched release.

Verification

  • npm run type-check — ✅ pass
  • CI=true npx vitest run — ✅ 6 files, 20/20 tests passed
  • npm run lint:ci — ✅ pass
  • npm run check (tsc + vite build + wrangler deploy --dry-run) — ✅ pass
  • npm audit — ✅ 0 high, 0 critical, 4 moderate (all triaged above)

…/ XSS / constructor injection advisories)

React Router advisories affecting <=7.17.0:
- GHSA open redirect via backslash in <Link> and useNavigate (CVE-2025-68470 bypass)
- GHSA-337j-9hxr-rhxg arbitrary constructor injection via deserializeErrors() in SSR hydration
- GHSA open redirect leading to XSS (react-router-dom 6.30.2-6.30.4)

Fix is a major version bump (6 -> 7) in library mode. App usage
(BrowserRouter, Routes, Route, Link in web/main.tsx, web/App.tsx) is
API-compatible across the v6->v7 boundary; no source changes needed.

Ref: #8
@rome2o
rome2o merged commit 6e83d8d into main Aug 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant