Skip to content

Add repo security and permission checks - #8

Merged
rome2o merged 1 commit into
mainfrom
feat/repo-security-checks
Nov 12, 2026
Merged

rome2o merged 1 commit into
mainfrom
feat/repo-security-checks

Conversation

@rome2o

@rome2o rome2o commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds repo security and permission checks to the github-seo skill. Triggered by an audit of a public repo that passed every SEO check while its Pages branch was unprotected. Read-only (GET only), stdlib only, report and recommend only. Checks that need admin print MANUAL ("could not check, needs admin") rather than guessing.

  • check_repo_seo.py: new security section (default branch and Pages branch rules, secret scanning, push protection, Dependabot, private vulnerability reporting, Actions token and fork PR approval). Flags --security-only and --skip-security.
  • references/repo-security-checklist.md: evidence labels (verified/observed/general, 2026-11-13) and exact gh api commands, plus what a read-only token sees.
  • SKILL.md Step 1b, Reporting back; evals (2 trigger, 2 not-trigger, 1 quality); CHANGELOG. Existing "set up branch protection rules on main" should_not_trigger case kept: the skill audits, never configures.
  • No plugin version bump (CONTRIBUTING does not require one). Not verified: CODEOWNERS and code scanning are documented in the checklist but not scored by the script.

Real output

rome2o/tokenpower-claude (admin token, main and gh-pages rulesets active):

PASS   token permission                 admin
PASS   default branch rules             main: deletion blocked, force-push blocked, PR required
PASS   pages branch rules               gh-pages: deletion blocked, force-push blocked
PASS   secret scanning                  enabled
PASS   push protection                  enabled
WARN   dependabot security updates      disabled
WARN   dependabot alerts                disabled (HTTP 404)
PASS   private vulnerability reporting  enabled
PASS   actions default token            default_workflow_permissions=read
PASS   actions approve PRs              can_approve_pull_request_reviews=False
PASS   fork PR approval                 first_time_contributors

rome2o/uptime-monitor (admin token, no rulesets, empty repo on master):

PASS   token permission                 admin
FAIL   default branch rules             master: missing deletion blocked, force-push blocked, PR required
PASS   secret scanning                  enabled
PASS   push protection                  enabled
WARN   dependabot security updates      disabled
WARN   dependabot alerts                disabled (HTTP 404)
WARN   private vulnerability reporting  disabled. SECURITY.md should say where to report.
PASS   actions default token            default_workflow_permissions=read
PASS   actions approve PRs              can_approve_pull_request_reviews=False
PASS   fork PR approval                 first_time_contributors

cli/cli (read-only token, shows MANUAL degradation):

WARN   token permission                 read or write only. Settings checks below are limited.
WARN   default branch rules             trunk: missing deletion blocked, force-push blocked, PR required (legacy branch protection could not check, needs admin)
MANUAL secret scanning                  could not check, needs admin
MANUAL push protection                  could not check, needs admin
MANUAL dependabot security updates      could not check, needs admin
MANUAL dependabot alerts                could not check, needs admin
PASS   private vulnerability reporting  enabled
MANUAL actions workflow permissions     HTTP 403, could not check, needs admin
MANUAL fork PR approval                 HTTP 403, could not check, needs admin

Validation: python3 scripts/validate_skill.py prints ok; py_compile passes. No other tests exist in the repo.

🤖 Generated with Claude Code

Read-only security section in check_repo_seo.py (branch and Pages rules,
secret scanning, push protection, Dependabot, private vulnerability
reporting, Actions permissions), checklist reference, SKILL.md step,
evals and changelog.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@rome2o
rome2o merged commit daeceeb into main Nov 12, 2026
3 checks passed
@rome2o rome2o mentioned this pull request Nov 12, 2026
@superkindhq

superkindhq Bot commented Nov 14, 2026

Copy link
Copy Markdown

post-merge audit — github-seo-skill #8/#9 (rome2o, merged 2026-11-12, zero review)

Executed at main tip 8203111: ran the new security checker itself against a live repo —

WARN   token permission                 read or write only. Settings checks below are limited.
PASS   default branch rules             main: deletion blocked, force-push blocked, PR required
MANUAL secret scanning / push protection / dependabot*      could not check, needs admin
WARN   private vulnerability reporting  disabled. SECURITY.md should say where to report.
MANUAL actions workflow permissions     HTTP 403, could not check, needs admin
MANUAL fork PR approval                 HTTP 403, could not check, needs admin

Verdict: 🟢 solid. GET-only verified in code (no POST/PUT/PATCH/DELETE anywhere); admin-gated checks degrade to MANUAL instead of guessing; rulesets + legacy-projection logic handles both protection models; mutual-exclusion of --security-only/--skip-security guarded. #9 is a version bump + release notes of the same content.

One observation from the live run: on its own repo the skill correctly reports private vulnerability reporting: disabled — consider enabling it here as a dogfood fix (needs admin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant