fix: MAU response shape handling (0.10.1) - #48
Merged
Conversation
Singleton account/transaction/document objects were treated as lists, causing rows.map is not a function on mau accounts. Co-authored-by: Cursor <cursoragent@cursor.com>
Live Mauritius payloads can put accounts/transactions at the top level instead of under data; normalize both shapes. Co-authored-by: Cursor <cursoragent@cursor.com>
Live balance responses nest the record under accounts.balance; expose the inner balance object for table/JSON output. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis change adds shared MAU response normalization helpers, updates MAU commands to use them for accounts, balances, transactions, and documents, tightens list handling for non-array items, adds test coverage for the new parsing paths, and bumps the package and ChangesMAU response normalization
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datawrapper,accounts.balancenesting) somau accounts/balances/ related commands render correctlyinvestec-mau-apito ^0.1.1Follow-up to #47 with fixes found during live MAU testing.
Test plan
npm run test:runpassesipb mau accounts(norows.mapcrash)ipb mau accounts --jsonreturns an array of account objectsipb mau balances <id> --jsonreturns flat balance fields (not{ accounts: { balance: … } })ipb mau transactions <id> --from … --to …works with live date rangeMade with Cursor
Summary by CodeRabbit
Bug Fixes
Tests
Chores