Skip to content

fix: use bash for Windows release rename step - #45

Merged
devinpearson merged 1 commit into
mainfrom
fix/windows-rename-shell
Aug 3, 2026
Merged

fix: use bash for Windows release rename step#45
devinpearson merged 1 commit into
mainfrom
fix/windows-rename-shell

Conversation

@devinpearson

@devinpearson devinpearson commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Force shell: bash on the Windows binary rename step so POSIX if [ -f ... ] works on windows-latest (default PowerShell was failing with Missing '(' after 'if')

Test plan

  • Re-run Release Binaries for v0.9.3 (or tag a new patch)
  • Windows matrix job completes rename + checksum + artifact upload

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows release packaging by reliably identifying the expected binary.
    • Release builds now provide clearer diagnostics when the Windows binary is missing.

The rename script uses POSIX if/[ tests, which PowerShell rejects on windows-latest. Match the checksum step and force shell: bash.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 80e87d51-d558-49e8-9cba-e591dbe81239

📥 Commits

Reviewing files that changed from the base of the PR and between 0663b40 and f3061d6.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The Windows release workflow now runs the binary rename step with Bash. It fails explicitly when neither expected binary filename exists and lists the dist/ contents for diagnosis.

Changes

Windows release validation

Layer / File(s) Summary
Binary rename validation
.github/workflows/release.yml
The rename script runs with Bash. When no expected Windows binary exists, the script lists dist/ and exits with failure.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: using Bash for the Windows release rename step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-rename-shell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devinpearson
devinpearson merged commit 2eb72e9 into main Aug 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant