Repository navigation
docs: add endpoint delete and clarify CORS in API contract - #10
Merged
Merged
Conversation
Adds DELETE /v1/endpoints/:id (soft delete) to v1, drops the unreachable disabled endpoint status, adds the endpoint_limit_reached and endpoint_deleted errors, and documents the Vite dev proxy for local development.
This was referenced Oct 26, 2026
AbdikhaniAbdirashid
approved these changes
Oct 26, 2026
AbdikhaniAbdirashid
approved these changes
Oct 27, 2026
AbdikhaniAbdirashid
left a comment
Collaborator
There was a problem hiding this comment.
Re-approving after the new commit - the 503 note is exactly the clarification I was after, and it belongs in the contract rather than only in the code.
Nothing else changed since my first read, so the three answers still stand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8, answering the three review questions there.
Changes to
docs/api.mdDELETE /v1/endpoints/:idis now part of v1. It's a soft delete: the endpoint disappears from the list and frees its slot, but its old deliveries still show its name and URL. Deliveries still pending for it becomedeadwithlast_error: "endpoint_deleted". Without it, test typos would use up the 20 slots for good.EndpointStatusisactive | failing.disabledcould never occur in v1. Deleted endpoints simply aren't listed.409 endpoint_limit_reachedwhen creating a 21st endpoint;409 endpoint_deletedwhen replaying a delivery whose endpoint was deleted.409 in_flightis shown as "being sent right now, try again in a moment".https://cdn.myrelay.techandhttp://localhost:4173(Playwright's preview server in CI). For local development, the Vite dev server proxies/v1to the API, so CORS never applies. The config snippet is in the doc.docs/CONTEXT.mdlists the new route.The types block in
docs/api.mdcompiles with strict TypeScript.