Repository navigation
Fix order status never updating past placed - #11
Merged
Merged
Conversation
The order service never consumed order.accepted/order.ready, so its own row (the one GET /orders/:id actually reads) stayed "placed" forever even after the kitchen had accepted and readied the order. Kitchen only ever updated its own database, never order's. Added a consumer (order-events.ts, same extraction pattern as the outbox poller) that updates order's row on both events, with its own Redis idempotency namespace. Also strengthened the e2e test to assert the real public /orders/:id endpoint reaches "ready", not just kitchen's internal database — that's what should have caught this originally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan