Repository navigation
Fix CI: pin test timeout explicitly instead of relying on bunfig.toml - #10
Merged
Merged
Conversation
…bunfig.toml CI was failing on every run since Testcontainers/e2e tests were added: the e2e test's 5000ms default bun test timeout was being hit on GitHub Actions' slower runners, because bunfig.toml's configured 60000ms timeout wasn't taking effect there (it was on local dev, exposing a resolution difference tied to bun-version). Passing --timeout 60000 directly on each package's test script removes the dependency on that discovery working the same way across environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI has been failing since Testcontainers/e2e tests were added (visible on the last 2 merges to main). The e2e test hits bun's 5000ms default timeout on GitHub Actions' runners — bunfig.toml's configured 60000ms timeout isn't taking effect there the way it does locally. Passing
--timeout 60000explicitly on each package's test script removes the dependency on that resolution behaving the same way across environments/bun versions.Test plan
bun run testgreen locally across all packages