- test + fix for nil response#24
Merged
mattkasun merged 3 commits intodevilcove:masterfrom Sep 17, 2025
Merged
Conversation
- replace %w with %v for ErrHttpClient{Message}
Contributor
|
what problem does this solve? |
Contributor
Author
|
fixes a nil pointer dereference panic in GetResponse and GetJSON. |
mattkasun
requested changes
Sep 17, 2025
Co-authored-by: Matthew R Kasun <mkasun@gmail.com>
mattkasun
reviewed
Sep 17, 2025
Co-authored-by: Matthew R Kasun <mkasun@gmail.com>
mattkasun
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nil pointer dereference in error handling
replace %w with %v for ErrHttpClient{Message}