Skip to content

Add expanded De-Clipper, De-Esser, De-Hummer and De-Noiser windows - #99

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-13
Nov 16, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-13

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

Summary

The window button on the restoration devices now opens their expanded windows.

  • De-Clipper joins the waveshaper windows. It draws its transfer curve held at the threshold next to two cycles of a sine wave. The reduction is lit against unity. The card holds Threshold, Ceiling, Oversampling (pills) and Mix.
  • De-Esser, De-Hummer and De-Noiser draw their card's graph at window size. Each graph has a dB ladder, a frequency axis, a caption (the band, the hum frequency or the gate threshold) and a legend. Each window has one card with every control, and De-Esser's card includes the Listen pills.
  • Pointer events from a window carry phase + 16, so drags on the threshold and reduction handles are hit-tested at window size.

Screenshots

Device Before (floating card) After (window)
De-Clipper
De-Esser
De-Hummer
De-Noiser

Benchmark

Build time per frame, measured with cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture:

Device Card (µs) Window (µs)
De-Clipper 120.7 238.6
De-Esser 115.7 135.9
De-Hummer 141.9 145.1
De-Noiser 12.7 23.5

Every window stays within about 2x its card.

Tests

New tests:

  • declipper_window_shows_the_transfer_and_every_control
  • repair_windows_draw_the_graph_and_every_control, which includes a De-Noiser drag at window size
  • declipper_transfer_holds_at_the_threshold

All 325 app tests pass and clippy is clean. README, docs/devices.md and CHANGELOG are updated.


Generated by Claude Code

De-Clipper joins the waveshaper windows with its card's law: the transfer held at the threshold beside two cycles of a sine, the reduction lit against unity, and a card with Threshold, Ceiling, Oversampling and Mix. De-Esser, De-Hummer and De-Noiser draw the card's graph at window size (WindowScope, WIN_PLOT) with a dB ladder, a frequency axis, a caption and a legend, and one card of every control; their pointer events carry phase + 16 so drags are hit tested at that size. Tests declipper_window_shows_the_transfer_and_every_control, repair_windows_draw_the_graph_and_every_control and declipper_transfer_holds_at_the_threshold; all four in the window bench; docs updated.
@chrislaupama
chrislaupama marked this pull request as ready for review November 16, 2026 02:40
@chrislaupama
chrislaupama merged commit 172ebfe into main Nov 16, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-13 branch November 16, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant