Repository navigation
Add expanded De-Clipper, De-Esser, De-Hummer and De-Noiser windows - #99
Merged
Merged
Conversation
De-Clipper joins the waveshaper windows with its card's law: the transfer held at the threshold beside two cycles of a sine, the reduction lit against unity, and a card with Threshold, Ceiling, Oversampling and Mix. De-Esser, De-Hummer and De-Noiser draw the card's graph at window size (WindowScope, WIN_PLOT) with a dB ladder, a frequency axis, a caption and a legend, and one card of every control; their pointer events carry phase + 16 so drags are hit tested at that size. Tests declipper_window_shows_the_transfer_and_every_control, repair_windows_draw_the_graph_and_every_control and declipper_transfer_holds_at_the_threshold; all four in the window bench; docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The window button on the restoration devices now opens their expanded windows.
Screenshots
Benchmark
Build time per frame, measured with
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture:Every window stays within about 2x its card.
Tests
New tests:
declipper_window_shows_the_transfer_and_every_controlrepair_windows_draw_the_graph_and_every_control, which includes a De-Noiser drag at window sizedeclipper_transfer_holds_at_the_thresholdAll 325 app tests pass and clippy is clean. README, docs/devices.md and CHANGELOG are updated.
Generated by Claude Code