Repository navigation
Add expanded Trance Gate window - #98
Merged
Merged
Conversation
The card's ring, pattern track and envelope are drawn and hit tested from a geometry scope (TG_CARD or TG_WIN), so the window shows them at its own size: the ring and pattern track on a panel down the left, the envelope across the display, and a card with Attack, Decay, Sustain, Release, Swing and Mix. Window editor events carry kind + 16. Test trance_gate_window_toggles_steps_on_its_own_ring; added to the window bench; docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
TgScopewithTG_CARDorTG_WIN). Everything the card does works in the window the same way: painting steps, dragging the step count, the rate menu, picking a pattern, dragging the envelope handles.Builder::left).trance_gate_window_toggles_steps_on_its_own_ring. Trance Gate added to the window bench.Screenshots
Before (card in the floating panel):
After:
Benchmark
bench_dynamics_windows(release, Linux cloud container), per build: Trance Gate card 319.0 µs, window 301.2 µs. The window draws the same picture as the card, at a larger size.Generated by Claude Code