Repository navigation
Add expanded windows for Compressor, Limiter, Gate and Glue Compressor - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Compressor, Limiter, Gate and Glue Compressor now open an expanded window from the window button instead of the card in a window.
device_window_dynamics.rs). Each meter poll appends the device's input, output and gain reduction to a ring of the last 10.5 s. The display draws a gain-reduction lane (0 to −18 dB) over a dBFS level plot, one pixel per dB in both, with the time axis, a legend and the live readout ("Gain Reduction 0.0 dB Peak 0.0").Screenshots
Device only, cropped to the window. Before: the card in a window. After: the expanded window.
Benchmarks
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapturebuilds the card and the whole window (with a full 10.5 s history, 630 samples) 500 times and averages (4-core Xeon @ 2.1 GHz, Linux).Every build stays under 1 ms, and a window only rebuilds while it is open and its history moves (it rests once the input has been silent for the whole span). Recording the history reads the readouts the meters already poll; the audio path is unchanged.
Docs
Generated by Claude Code