Skip to content

Release packaging: find the plugin scanner under Cargo 1.100's build layout - #72

Merged
chrislaupama merged 1 commit into
mainfrom
release-scanner-path
Nov 14, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
release-scanner-path

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

This fixes the package jobs (Linux x86_64/aarch64, macOS, Windows) that failed on #70.

Cause

Rust 1.100 came out Nov 12 and moved build-script output from build/<crate>-<hash>/out to build/<crate>/<hash>/out. I checked this with a one-crate project: on 1.100 the OUT_DIR was target/release/build/bdtest/d82ec6eddebcb559/out. The packaging still searched with the old glob dstudio-engine-*/out/build/. That's why every package job failed with "plugin scanner not found" as soon as the hosted runners switched to the new stable toolchain. The CI app jobs kept passing because the app reads the scanner path that build.rs bakes in.

Fix

  • New tools/release/find-scanner.sh <profile dir>. It searches both layouts and prints the newest scanner. If it finds none, it fails with a message instead of exiting silently with code 2.
  • Callers switched to it:
    • package-linux.sh
    • package-macos.sh
    • the macOS build job in release.yml
    • tools/macos-bundle.sh
  • Windows: package-windows.ps1 matches both layouts in its regex.
  • New test, run in lint: tools/release/test-find-scanner.sh checks six cases:
    • the old layout
    • the new layout
    • the .exe name
    • the newest of two builds
    • another crate's file being ignored
    • a missing build dir

Tests

$ tools/release/test-find-scanner.sh
find-scanner: all checks passed
$ tools/release/find-scanner.sh target/release          # a real Cargo 1.97 build
target/release/build/dstudio-engine-009ecbe63748722c/out/build/dstudio_plugin_scanner
$ tools/release/package-linux.sh 0.1.0-test x86_64 /tmp/pkgout
/tmp/pkgout/Device-0.1.0-test-linux-x86_64.tar.gz       # holds bin/device-studio and bin/dstudio_plugin_scanner

This PR changes the packaging, so the Release workflow runs on it and packages all four targets with Rust 1.100. That's the real check.

No screenshots and no benchmarks: this only touches build tooling.


Generated by Claude Code

…layout

Rust 1.100 (Nov 12) moved build script output from
build/<crate>-<hash>/out to build/<crate>/<hash>/out. The release
packaging looked for the plugin scanner with the old glob, so every
package job (Linux, macOS, Windows) failed with "plugin scanner not
found" as soon as the runners picked up the new stable toolchain.

tools/release/find-scanner.sh now finds it under either layout and
fails with a clear message; the Linux and macOS packaging scripts, the
macOS build job and tools/macos-bundle.sh use it, and the Windows script
matches both layouts. tools/release/test-find-scanner.sh checks both
layouts, a Windows name, the newest of two builds and the failure cases,
and runs in lint.
@chrislaupama
chrislaupama marked this pull request as ready for review November 14, 2026 22:38
@chrislaupama
chrislaupama merged commit e20abf0 into main Nov 14, 2026
24 checks passed
@chrislaupama
chrislaupama deleted the release-scanner-path branch November 14, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant