Repository navigation
Release packaging: find the plugin scanner under Cargo 1.100's build layout - #72
Merged
Merged
Conversation
…layout Rust 1.100 (Nov 12) moved build script output from build/<crate>-<hash>/out to build/<crate>/<hash>/out. The release packaging looked for the plugin scanner with the old glob, so every package job (Linux, macOS, Windows) failed with "plugin scanner not found" as soon as the runners picked up the new stable toolchain. tools/release/find-scanner.sh now finds it under either layout and fails with a clear message; the Linux and macOS packaging scripts, the macOS build job and tools/macos-bundle.sh use it, and the Windows script matches both layouts. tools/release/test-find-scanner.sh checks both layouts, a Windows name, the newest of two builds and the failure cases, and runs in lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the package jobs (Linux x86_64/aarch64, macOS, Windows) that failed on #70.
Cause
Rust 1.100 came out Nov 12 and moved build-script output from
build/<crate>-<hash>/outtobuild/<crate>/<hash>/out. I checked this with a one-crate project: on 1.100 theOUT_DIRwastarget/release/build/bdtest/d82ec6eddebcb559/out. The packaging still searched with the old globdstudio-engine-*/out/build/. That's why every package job failed with "plugin scanner not found" as soon as the hosted runners switched to the new stable toolchain. The CIappjobs kept passing because the app reads the scanner path thatbuild.rsbakes in.Fix
tools/release/find-scanner.sh <profile dir>. It searches both layouts and prints the newest scanner. If it finds none, it fails with a message instead of exiting silently with code 2.package-linux.shpackage-macos.shrelease.ymltools/macos-bundle.shpackage-windows.ps1matches both layouts in its regex.lint:tools/release/test-find-scanner.shchecks six cases:.exenameTests
This PR changes the packaging, so the Release workflow runs on it and packages all four targets with Rust 1.100. That's the real check.
No screenshots and no benchmarks: this only touches build tooling.
Generated by Claude Code