Repository navigation
Make the Callgrind performance check report on every pull request - #69
Merged
Merged
Conversation
The Performance workflow only started on pull requests that touched the benchmarked paths, so its Instructions check could not be required on main: every other pull request would wait for it forever. Pull requests now always start the workflow, and a small changes job skips both comparisons when nothing the benchmarks build changed (a skipped job counts as passed). If that job fails the comparison runs anyway. Pushes to main keep their path filter. The build docs now list lint and Instructions (Linux, Callgrind) as required checks next to the three build-test ones. For #35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #35. The decision is to require lint and Instructions (Linux, Callgrind) on
main, in addition to the three build-test checks. RustSec, Dependency review and the timing jobs stay advisory.Why a workflow change first
The Performance workflow used a
pathsfilter onpull_request, so it never started on a PR that doesn't touch the benchmarked code. A required check that never reports would block those PRs forever.What changes
pull_requestno longer has a path filter. Pushes tomainkeep theirs.changesjob. It diffs the PR against its base. If nothing underengine/,crates/dstudio-core/,Cargo.lock,tools/perf/orperf.ymlchanged, it outputsperf=false.needs: changesand are skipped onperf=false, and GitHub counts a skipped job as passed for required checks. Ifchangesitself fails, its output is empty and the comparison still runs, so a failure there can't open a bypass.docs/building.mdlists the new required checks and explains the skip.After this merges, branch protection on
maingetslintandInstructions (Linux, Callgrind)as required checks.Verification
perf.ymland docs, the workflow runs the full comparison, becauseperf.ymlitself is a benchmarked path.Instructions (Linux, Callgrind)as skipped and passing.There are no screenshots because nothing visual changes. There are no benchmarks for the same reason: nothing in the app or engine is touched.
Generated by Claude Code