Repository navigation
Export to MP3 - #58
Merged
Merged
Conversation
The Export dialog's Format segments now pick WAV or MP3 for Mixdown and Stems. With MP3 the second segments pick 192 or 320 kbps in place of the bit depth; rate and range work as for WAV, the Name field ends in .mp3 and the size estimate follows the bitrate. Live set exports stay WAV. Encoding goes through LAME (mp3lame-encoder, built from source, LGPL), CBR joint stereo at quality 2, with the Info tag so decoders trim the encoder delay and padding. Closes #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #28. The Export dialog's WAV / MP3 segments now work for Mixdown and Stems.
.mp3, the Mixdown card reads "MP3 320 kbps", Stems reads "N MP3 files", and the size estimate follows the bitrate.mp3lame-encoder0.3.0 /mp3lame-sys0.2.0, which compilelibmp3lamefrom source (no system library needed on macOS, Windows or Linux). The output is CBR joint stereo at LAME quality 2. LAME's Info tag goes in the first frame, so decoders trim the encoder delay and padding and the file has exactly the rendered length.engine/third_party_licenses.mdand in the README.review-export-mp3.Tests:
mp3::testsencodes one second of a sine at both bitrates and reads it back through the engine's MP3 decoder. It checks the exact frame count, a peak within 0.05 of the source, and a size close to the estimate.dialogs::tests::a_mixdown_exports_as_mp3_with_the_picked_rate_and_lengthruns a real Mixdown export to MP3 at 44.1 kHz and checks the file's rate and length, and that the name ending follows the format.Screenshots
Before (main): MP3 only showed a "not implemented" status.
After, WAV picked (unchanged):
After, MP3 picked:
Benchmarks
The WAV export path is unchanged. Encoding time for 60 s of 48 kHz stereo (release build, Linux, Xeon @ 2.1 GHz, one run):
That is about 75x real time, on top of the render itself.
Docs
Generated by Claude Code