Repository navigation
Watch the engine's pinned third-party sources - #43
Merged
Merged
Conversation
The hosted Linux runner moved to Ubuntu 26.04, whose GCC 15 reports -Wnull-dereference (an error in CI) in three files: - Copies of file-scope default vectors written through operator[]: GCC can't see that a dynamically initialised global is non-empty. Use .at() for those writes in test_mod_routes.cpp and bench_devices.cpp. - memcpy from an empty vector's data() in bench_devices.cpp: skip the copy when there is nothing to copy (memcpy from null is undefined even for zero bytes). - sorted.back() on a possibly empty timing vector in bench_render.cpp: guard it the way run_render already does.
- engine/CMakeLists.txt records the commit behind every pinned tag and the configure step fails if a fetched checkout is at a different commit. - tools/ci/engine_pins.py compares each pin with upstream (newer release tag, moved tag, or a change to a decoder file we compile). - The weekly Engine pins workflow keeps one issue open while something is behind and closes it when all pins are current. - docs/building.md describes how engine dependencies are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #39. The engine's
FetchContentpins are invisible to Dependabot andcargo audit; this makes them checked.engine/CMakeLists.txtrecords the commit behind every pinned tag (DSTUDIO_<NAME>_TAG_COMMIT). After fetching, the configure step compares each checkout'sHEADwith its pin and stops if they differ, so a tag moved upstream cannot change what gets built. Skipped forFETCHCONTENT_SOURCE_DIR_<NAME>overrides.tools/ci/engine_pins.py. Reads the pins fromengine/CMakeLists.txtand compares each with upstream using only git: a newer release tag, a moved or deleted tag, and for the commit pins (dr_libs, stb) a change upstream to one of the files we compile. Prints a Markdown report;--self-testchecks the parser and comparison offline and runs inlint.docs/building.mdhas a new "Engine dependencies" section with the update steps.Today's report from the script:
DSTUDIO_CLAP_TAG1.2.101.2.10DSTUDIO_VST3SDK_TAGv3.8.1_build_84v3.8.1_build_84DSTUDIO_STRETCH_TAG1.4.01.4.0DSTUDIO_LINEAR_TAG0.6.40.6.6DSTUDIO_DR_LIBS_COMMIT35b5c392cc15f12e197fd462DSTUDIO_STB_COMMIT4e9b368bfc07965c80bc0b13The updates themselves are left for a separate change (the workflow's first run will open the issue for them).
Checked locally: a correct pin configures; a deliberately wrong
DSTUDIO_CLAP_TAG_COMMITstops the configure step with the expected message.Screenshots
No visual change.
Benchmarks
No runtime code changes. The configure step gains six
git rev-parsecalls.Docs
Generated by Claude Code