Repository navigation
CI: parallel tests and app jobs, change-aware runs, blocking Windows smoke tests #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6b657bd
CI: run tests and the app smoke tests side by side, behind the same r…
chrislaupama 31cece7
CI: prepare-target.sh runs on macOS's bash 3.2
chrislaupama 4665732
CI: take the Linux screenshot alongside the two self-tests
chrislaupama c6688f5
CI: zero the restored ccache statistics before building
chrislaupama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| #!/usr/bin/env bash | ||
| # Decides which parts of CI a pull request needs, from the paths it changes. | ||
| # | ||
| # git diff --name-only HEAD^1 HEAD | tools/ci/changes.sh | ||
| # | ||
| # Prints three lines, each `true` or `false`: | ||
| # | ||
| # engine= the standalone engine build (CMake, warnings as errors) and ctest | ||
| # rust= `cargo test` over the workspace (which also builds the engine through build.rs) | ||
| # app= the app's release build and its smoke tests (screenshot, self-test) | ||
| # | ||
| # A part is skipped only when every changed path is known not to reach it. Anything not | ||
| # listed below (Cargo.toml, Cargo.lock, the CI workflow, tools/ci/, a new top-level folder) | ||
| # runs everything. Pushes to main and scheduled runs do not call this: they run everything. | ||
| # | ||
| # documentation (*.md, docs/, specs/, .agents/, LICENSE, | ||
| # issue templates, dependabot.yml) nothing | ||
| # engine/tests/, engine/bench/, engine/tools/ engine (build.rs builds none of them) | ||
| # engine/ (anything else) engine, rust, app | ||
| # crates/*/tests/, crates/*/benches/ rust (not part of the app binary) | ||
| # crates/ (anything else) rust, app | ||
| # tools/perf/, tools/release/, tools/art/, | ||
| # tools/agents/, tools/macos-bundle.sh, | ||
| # .github/workflows/{perf,release}.yml, | ||
| # ui-spike/ nothing (their own workflows, or no CI) | ||
| # | ||
| # Test it with tools/ci/test-changes.sh. | ||
| set -euo pipefail | ||
|
|
||
| engine=false | ||
| rust=false | ||
| app=false | ||
| any=false | ||
| while IFS= read -r path || [ -n "$path" ]; do | ||
| path="${path%$'\r'}" | ||
| [ -n "$path" ] || continue | ||
| any=true | ||
| case "$path" in | ||
| *.md | docs/* | specs/* | .agents/* | LICENSE* | .github/ISSUE_TEMPLATE/* | .github/dependabot.yml) ;; | ||
| engine/tests/* | engine/bench/* | engine/tools/*) engine=true ;; | ||
| engine/*) engine=true rust=true app=true ;; | ||
| crates/*/tests/* | crates/*/benches/*) rust=true ;; | ||
| crates/*) rust=true app=true ;; | ||
| tools/perf/* | tools/release/* | tools/art/* | tools/agents/* | tools/macos-bundle.sh) ;; | ||
| .github/workflows/perf.yml | .github/workflows/release.yml | ui-spike/*) ;; | ||
| *) engine=true rust=true app=true ;; | ||
| esac | ||
| done | ||
|
|
||
| # No list at all (the diff failed or was empty): run everything rather than nothing. | ||
| if [ "$any" = false ]; then | ||
| engine=true rust=true app=true | ||
| fi | ||
|
|
||
| echo "engine=$engine" | ||
| echo "rust=$rust" | ||
| echo "app=$app" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.