Repository navigation
Show the window button only on devices with an expanded window - #103
Merged
Merged
Conversation
Built-in cards now offer the window button exactly when the device has an expanded window. The LFO card, which has one, now shows it; the Rack and the instruments keep everything in their card. Tests cover every built-in device and the card flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Built-in device cards now show the window button exactly when the device has an expanded window (
device_window::has_window).Screenshots
LFO card, before and after:
Tests
every_effect_has_a_window_and_no_instrument_does: every built-in effect has a window (the Rack excepted), and no instrument has one.builtin_cards_offer_the_window_only_when_there_is_one: Delay, LFO and Trance Gate cards offer the window, the Rack card does not.Performance
No effect on audio or drawing: the card computes one boolean per build.
Docs: README, CHANGELOG and docs/devices.md updated.
Generated by Claude Code