Skip to content

Show the window button only on devices with an expanded window - #103

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-17
Nov 16, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-17

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

What

Built-in device cards now show the window button exactly when the device has an expanded window (device_window::has_window).

  • The LFO card had a window (added in Add the expanded LFO window #102) but no button to open it, because the button was tied to the plain effect card layout. It now shows the button.
  • The Rack and the instruments (Synth, Sampler, Drum Rack, Pad Sampler) keep everything in their card and show no window button. They have no expanded window by design.

Screenshots

LFO card, before and after:

Before After
before after

Tests

  • every_effect_has_a_window_and_no_instrument_does: every built-in effect has a window (the Rack excepted), and no instrument has one.
  • builtin_cards_offer_the_window_only_when_there_is_one: Delay, LFO and Trance Gate cards offer the window, the Rack card does not.
  • Full app tests pass (332) and clippy is clean.

Performance

No effect on audio or drawing: the card computes one boolean per build.

Docs: README, CHANGELOG and docs/devices.md updated.


Generated by Claude Code

Built-in cards now offer the window button exactly when the device has an
expanded window. The LFO card, which has one, now shows it; the Rack and
the instruments keep everything in their card. Tests cover every built-in
device and the card flag.
@chrislaupama
chrislaupama marked this pull request as ready for review November 16, 2026 09:25
@chrislaupama
chrislaupama merged commit 6223a1a into main Nov 16, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-17 branch November 16, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant