Skip to content

Add the expanded LFO window - #102

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-16
Nov 16, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-16

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

Summary

The window button on the LFO now opens its own expanded window.

  • Wave display: two cycles of the wave across the full width of the window. There are no meters, because the LFO makes no sound. The display shows:
    • phase quarters
    • the live position as a dot
    • the card's Rate / Depth drag: drag sideways to change Rate, up or down to change Depth
    • a caption with the shape and the cycle length (for example "Sine 1/4 per cycle")
  • Card below: Shape, Timebase (Free or Sync), Rate (the free or synced knob, matching Timebase), Phase and Depth. Modulation targets are still listed on the device card.

Screenshots

Before (floating card) After (window)

Benchmark

Build time per frame, measured with cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture:

Device Card (µs) Window (µs)
LFO 32.4 42.1

Tests

  • New test lfo_window_draws_the_wave_and_every_control. It checks the drag zone's parameters, the caption, the knobs, and that the Rate knob switches when Timebase changes.
  • All 330 app tests pass and clippy is clean.
  • README, docs/devices.md and CHANGELOG are updated.

Generated by Claude Code

The window draws two cycles of the wave across its full width (no meters: the LFO makes no sound) with phase quarters, the live position dotted and the card's Rate / Depth drag zone, captioned with the shape and the cycle length, over Shape, Timebase, Rate (free or synced), Phase and Depth. Test lfo_window_draws_the_wave_and_every_control; LFO in the window bench; docs updated.
@chrislaupama
chrislaupama marked this pull request as ready for review November 16, 2026 04:05
@chrislaupama
chrislaupama merged commit d4ef661 into main Nov 16, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-16 branch November 16, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant