Repository navigation
Add the expanded LFO window - #102
Merged
Merged
Conversation
The window draws two cycles of the wave across its full width (no meters: the LFO makes no sound) with phase quarters, the live position dotted and the card's Rate / Depth drag zone, captioned with the shape and the cycle length, over Shape, Timebase, Rate (free or synced), Phase and Depth. Test lfo_window_draws_the_wave_and_every_control; LFO in the window bench; docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The window button on the LFO now opens its own expanded window.
Screenshots
Benchmark
Build time per frame, measured with
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture:Tests
lfo_window_draws_the_wave_and_every_control. It checks the drag zone's parameters, the caption, the knobs, and that the Rate knob switches when Timebase changes.Generated by Claude Code