Repository navigation
Add the expanded Shaper window - #101
Merged
Merged
Conversation
The window draws the card's editor in its own geometry (ShGeo: SH_CARD or SH_WIN, set by ShScope while drawing and hit testing): the lane tabs over the display, the Shape, Band and Trigger strip on its caption row, and the curve across the rest of the display, with the lane's Rate and Depth, the trigger's Threshold (inert while synced), Mix and Output in the card below. Window events carry kind + 16 so points, bends and tabs are hit tested at window size. Test shaper_window_draws_the_editor_and_picks_lanes_in_its_geometry; Shaper in the window bench; docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking the window button on Shaper now opens its expanded window.
sh_drawandsh_hitread their geometry fromShScope, which holds eitherSH_CARDorSH_WIN.Screenshots
Benchmark
Build time per frame (
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture):The window costs about the same as the card. The card itself was already this expensive before this change.
Tests
shaper_window_draws_the_editor_and_picks_lanes_in_its_geometry.Generated by Claude Code