Repository navigation
Add expanded Pitch Shifter, Grains and Pitch Corrector windows - #100
Merged
Merged
Conversation
Pitch Shifter draws the interval field at window size with the In and Out notes against an A4 reference, the semitone axis, the formant strip and a legend over Semitones, Cents, a Formant switch (Shift / Keep) and Mix. Grains draws the buffer with Position and Spray readouts, a pitch axis and a time axis, with Cloud / Rhythm and Freeze in the header and two cards whose timing controls follow the mode. Pitch Corrector draws the correction trace (shared with the card through trace_layers) over cent rules labelled from +100 to -100, with Follow, Key, Scale, Speed, Retune Speed, Humanize and Mix. Tests pitch_shifter_window_shows_the_interval_and_every_control, grains_window_shows_the_buffer_and_both_cards and pitch_corrector_window_shows_the_trace_rules_and_every_control; all three in the window bench; docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The window button on the pitch devices now opens an expanded window for each one.
trace_layers.Screenshots
Benchmark
Build time per frame, measured with
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture:All three windows stay within about 2x their card.
Tests
pitch_shifter_window_shows_the_interval_and_every_control,grains_window_shows_the_buffer_and_both_cardsandpitch_corrector_window_shows_the_trace_rules_and_every_control.Generated by Claude Code