Skip to content

Add expanded Pitch Shifter, Grains and Pitch Corrector windows - #100

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-14
Nov 16, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-14

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

Summary

The window button on the pitch devices now opens an expanded window for each one.

  • Pitch Shifter
    • The display shows the interval field at window size.
    • The In and Out notes are labelled against an A4 reference (for example "A4, In (ref) 440.0 Hz" and "E5, Out 659.3 Hz").
    • Below the field are the semitone axis from −24 to +24 st, the formant strip with its caption ("Follows the shift" or "Held in place"), and a legend.
    • The card has Semitones, Cents, a Formant switch (Shift or Keep) and Mix.
  • Grains
    • The display shows the buffer with Position and Spray readouts, a pitch axis down the right edge and a time axis below.
    • The header has Cloud / Rhythm and Freeze.
    • There are two cards:
      • Position, Spray and Drift; Size, Density and Shape; Pitch, Spread, Scale and Reverse.
      • Width, Feedback, Blur, Tone and Space; Character; Mix and Mix Lock; Output.
    • In Rhythm mode the card swaps in the Position note, Rate, Gate and Chance, and Spread goes inert.
  • Pitch Corrector
    • The display shows the correction trace over cent rules every 25 ct, labelled from +100 to −100.
    • The trace drawing is shared with the card through trace_layers.
    • The card has Follow, Key, Scale, Speed, Retune Speed, Humanize and Mix. Key is inert while Follow is set to Project.

Screenshots

Device Before (floating card) After (window)
Pitch Shifter
Grains
Pitch Corrector

Benchmark

Build time per frame, measured with cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture:

Device Card (µs) Window (µs)
Pitch Shifter 20.0 31.7
Grains 25.9 39.3
Pitch Corrector 7.4 12.2

All three windows stay within about 2x their card.

Tests

  • Added pitch_shifter_window_shows_the_interval_and_every_control, grains_window_shows_the_buffer_and_both_cards and pitch_corrector_window_shows_the_trace_rules_and_every_control.
  • All 328 app tests pass and clippy is clean.
  • README, docs/devices.md and CHANGELOG are updated.

Generated by Claude Code

Pitch Shifter draws the interval field at window size with the In and Out notes against an A4 reference, the semitone axis, the formant strip and a legend over Semitones, Cents, a Formant switch (Shift / Keep) and Mix. Grains draws the buffer with Position and Spray readouts, a pitch axis and a time axis, with Cloud / Rhythm and Freeze in the header and two cards whose timing controls follow the mode. Pitch Corrector draws the correction trace (shared with the card through trace_layers) over cent rules labelled from +100 to -100, with Follow, Key, Scale, Speed, Retune Speed, Humanize and Mix. Tests pitch_shifter_window_shows_the_interval_and_every_control, grains_window_shows_the_buffer_and_both_cards and pitch_corrector_window_shows_the_trace_rules_and_every_control; all three in the window bench; docs updated.
@chrislaupama
chrislaupama marked this pull request as ready for review November 16, 2026 03:00
@chrislaupama
chrislaupama merged commit c06b111 into main Nov 16, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-14 branch November 16, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant