Skip to content

Decide which extra CI checks are required to merge #35

Closed

Description

@chrislaupama

Background

main requires the three build-test (macOS / Linux / Windows) checks. Since the CI rework (#22, #24, #25) and the Performance workflow, several other checks run on every pull request but are not required, so a PR can merge with them red:

Check Workflow What it catches
lint CI actionlint + shellcheck over workflows and scripts, the change-detection tests, the agent skill check
RustSec advisories Security cargo audit against the RustSec advisory database
Dependency review Security new dependencies with known vulnerabilities or disallowed licences
Instructions (Linux, Callgrind) Performance any engine/core benchmark that gets more than 1 % slower (the perf-regression-accepted label accepts a known regression)

Decision

For each, decide whether it becomes a required status check in the main branch protection (or ruleset):

  • lint: cheap and deterministic; recommended.
  • RustSec advisories: can go red without any change in the PR when a new advisory is published, which would block unrelated PRs until it's fixed. Optional.
  • Dependency review: only runs on PRs that change dependencies; optional.
  • Instructions (Linux, Callgrind): deterministic (noise measured below 0.1 %), and enforces the project's "no performance regressions" rule; recommended if the label escape hatch is acceptable.

The Linux/macOS/Windows timing jobs in the Performance workflow are warnings only and should stay optional.

If the repository moves to an organisation, branch protection moves with it, but check the required check names afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

github_actionsPull requests that update GitHub Actions codequestionFurther information is requested

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions