Desafio Skills: refactor-arch (auditoria + refatoração MVC agnóstica) - #17
Open
soulhave wants to merge 6 commits into
Open
Desafio Skills: refactor-arch (auditoria + refatoração MVC agnóstica)#17soulhave wants to merge 6 commits into
soulhave wants to merge 6 commits into
Conversation
…tos) - Skill de auditoria e refatoração MVC em .claude/skills/refactor-arch - Symlinks relativos nos 3 projetos apontando para a skill na raiz - README atualizado Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e evidência - Python organiza camadas MVC na raiz do projeto (só Node usa src/) - Checklist de validação interno/silencioso ao fim de cada fase (06-validation-checklist) - Fase 3 salva evidência auditável em reports/validation-project-<N>.md - Fase 2 passa a exigir mínimo de 5 findings - README atualizado Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fase 3 da skill refactor-arch. Quebra o monólito plano (app/controllers/ models/database) em camadas na raiz: config/, models/ e controllers/ por domínio, views/routes.py, middlewares/error_handler e services/. Correções: segredos via ambiente (sem SECRET_KEY/DEBUG hardcoded), SQL parametrizado (remove SQLi e o backdoor /admin/query), senhas com hash e fora das respostas, conexão por request (sem estado global), N+1 eliminado. Contrato externo preservado. Validado: PASS 22/22 endpoints. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fase 3 da skill refactor-arch. Quebra a God Class AppManager em camadas sob src/: models/ por entidade, services/ (checkout, report, payment, password), controllers/ magros, routes/, middlewares/ (errorHandler, requireAdmin), db/ e errors/. Composition root com injeção de dependência. Correções: segredos via ambiente (+ .env.example), sem número de cartão/chave em log (PCI), hashing forte, rotas admin protegidas por token, checkout com transação e delete em cascata (sem órfãos), N+1 do relatório eliminado. Contrato externo preservado. Validado: PASS 8/8 endpoints. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fase 3 da skill refactor-arch. Projeto já parcial (models/routes/services/ utils) evolui para MVC completo: controllers/ e views/ por recurso, config/settings, middlewares/ (auth, error_handler), schemas/ de validação e services reais (user, category, report). Correções: hash de senha forte e fora das respostas (era MD5 vazado), credenciais SMTP e SECRET_KEY via ambiente (+ .env.example), token assinado real no lugar de fake-jwt, regra de overdue centralizada no model, N+1 e except: nu tratados, APIs deprecated substituídas. Contrato externo preservado. Validado: PASS 23/23 verificações. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adiciona reports/audit-project-{1,2,3}.md (saída da Fase 2) e
reports/validation-project-{1,2,3}.md (evidência de boot + endpoints da
Fase 3). Preenche o README com as seções Construção da Skill, Resultados e
Como Executar. Ignora DECISIONS.md (notas internas de trabalho).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AllenLVieira
added a commit
to AllenLVieira/mba-ia-refactor-projects-skill
that referenced
this pull request
Aug 13, 2026
- stop logging full card + gateway key; log masked last4 only (catalog devfullcycle#17) - add POST /api/login with HS256 signed token; requireRole("admin") on DELETE /api/users/:id and GET /api/admin/financial-report (devfullcycle#18/devfullcycle#19/devfullcycle#21/devfullcycle#22) - add role column + admin seed; checkPassword with timingSafeEqual - app.js exposes createApp() factory for testability - add node:test suite (functional + negative-security + log scan): 12 tests - v2 report with traceability matrix and standardized result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entrega do desafio de criação de Skills — uma skill
refactor-archque analisa, audita e refatora qualquer backend para o padrão MVC, de forma agnóstica de tecnologia.O que foi entregue
.claude/skills/refactor-arch/(SKILL.md + 6 arquivos de referência), cobrindo as 5 áreas de conhecimento exigidas.reports/audit-project-{1,2,3}.md(Fase 2) ereports/validation-project-{1,2,3}.md(evidência de boot + endpoints da Fase 3).Resultados por projeto
Todos os critérios de aceite obrigatórios são atingidos nos 3 projetos: detecção correta de stack (Fase 1), ≥5 findings com ≥1 CRITICAL/HIGH (Fase 2) e aplicação funcionando após a refatoração (Fase 3).
🤖 Generated with Claude Code