fix: preserve declared chart series stroke geometry - #1594
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
deleted the
fix/issue-1590-chart-series-stroke-geometry
branch
September 6, 2026 08:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the chart series' declared cap, join and miter limit through parsing and rendering. Plot lines and legend samples now use the same geometry, matching native Excel's round/flat/square and round/miter/bevel controls. Values, width, color and marker paint are preserved.
Related: #1590. Related chart-style inheritance remains tracked separately in #1593.
Testing
cargo test --locked --workspace --no-fail-fast: 3,495 passed, 15 ignored, none failed.cargo clippy --locked --workspace --all-targets -- -D warnings,cargo fmt --all --check, andgit diff --check: passed.pdftotext -layouthas matching non-whitespace text.scripts/probes/issue-1590-series-stroke.jsonand the evidence README.Visual impact
Visual audit
tests/fixtures/xlsx/issue_1181_fit_to_height.xlsx; series-stroke variants inscripts/probes/issue-1590-series-stroke.jsonfixassets/bugfixes/issue-1590/layout-audit.jsonassets/bugfixes/issue-1590/render-clusters-page-1.json,assets/bugfixes/issue-1590/render-clusters-page-2.json,assets/bugfixes/issue-1590/render-clusters-page-3.json,assets/bugfixes/issue-1590/render-clusters-page-4.json,assets/bugfixes/issue-1590/render-clusters-page-5.json,assets/bugfixes/issue-1590/render-clusters-page-6.jsonassets/bugfixes/issue-1590/gt.jpgassets/bugfixes/issue-1590/before.jpgassets/bugfixes/issue-1590/after.jpgVisual comparison
Required inspection
Deviation audit
pdftotext -layout; narrow-cell ##### totals retained. Default extraction retains baseline reading-order differences and ten extra space-census entries.Checklist
Signed-off-byline