fix: paint chart axes before overlapping series markers - #1591
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paint line/scatter axes and ticks before series so opaque markers cover overlapping axis rules, matching native Excel. Preserve all existing primitive geometry, paint, opacity and values; hollow and disabled markers keep the rule visible.
Related: #1578.
Testing
cargo test --locked --workspace --no-fail-fast: 3,490 passed, 15 ignored. After updating to main 75d4046,cargo test --locked --workspace --libpassed 2,893 tests; all five two-page native probe outputs retain identical candidate paint traces.cargo clippy --locked --workspace --all-targets -- -D warnings,cargo fmt --all -- --check, andgit diff --checkpassed.pdftotext -layouthas matching non-whitespace text.scripts/probes/issue-1578-marker-overlap.jsonfor reproduction.Visual impact
Visual audit
tests/fixtures/xlsx/issue_1181_fit_to_height.xlsx; marker-only variants inscripts/probes/issue-1578-marker-overlap.jsonfixassets/bugfixes/issue-1578/layout-audit.jsonassets/bugfixes/issue-1578/render-clusters-page-1.json,assets/bugfixes/issue-1578/render-clusters-page-2.json,assets/bugfixes/issue-1578/render-clusters-page-3.json,assets/bugfixes/issue-1578/render-clusters-page-4.json,assets/bugfixes/issue-1578/render-clusters-page-5.jsonassets/bugfixes/issue-1578/gt.jpgassets/bugfixes/issue-1578/before.jpgassets/bugfixes/issue-1578/after.jpgassets/bugfixes/issue-1578/compare.jpgVisual comparison
Required inspection
Deviation audit
pdftotext -layout; both contain narrow-cell ##### totals. Default extraction retains baseline table reading-order differences and eight extra space-census entries.Checklist
Signed-off-byline