fix(pptx): preserve pair kerning across spaces - #1589
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the active font's pair kerning on both sides of PowerPoint spaces while retaining the 1/8pt advance grid. Arial
on Augnow fits an 88.5pt box as native PowerPoint does; previously it wrapped beforeAug. Combine pair and grid adjustments in one weak spacing element so both disappear at line boundaries and spaces remain searchable.Related: #1582.
Testing
cargo test --locked --workspace --no-fail-fast: all integration/doc suites passed; one old marker helper-call assertion required updating. The correctedcargo test --locked --workspace --libpassed all 2,892 library tests, including observable marker/body placement. Combined validation: 3,491 passed, 15 ignored.cargo clippy --locked --workspace --all-targets -- -D warnings,cargo fmt --all -- --check, andgit diff --checkpassed.Visual impact
Visual audit
tests/golden_mocks/business/sources/pptx/03_product_launch_en.pptx; one-factor letter and box-width probes reproduced in the evidence READMEfixassets/bugfixes/issue-1582/layout-audit.jsonassets/bugfixes/issue-1582/render-clusters-page-1.json,assets/bugfixes/issue-1582/render-clusters-page-2.json,assets/bugfixes/issue-1582/render-clusters-page-3.json,assets/bugfixes/issue-1582/render-clusters-page-4.json,assets/bugfixes/issue-1582/render-clusters-page-5.json,assets/bugfixes/issue-1582/render-clusters-page-6.json,assets/bugfixes/issue-1582/render-clusters-page-7.json,assets/bugfixes/issue-1582/render-clusters-page-8.json,assets/bugfixes/issue-1582/render-clusters-page-9.json,assets/bugfixes/issue-1582/render-clusters-page-10.json,assets/bugfixes/issue-1582/render-clusters-page-11.json,assets/bugfixes/issue-1582/render-clusters-page-12.json,assets/bugfixes/issue-1582/render-clusters-page-13.json,assets/bugfixes/issue-1582/render-clusters-page-14.json,assets/bugfixes/issue-1582/render-clusters-page-15.json,assets/bugfixes/issue-1582/render-clusters-page-16.jsonassets/bugfixes/issue-1582/gt.jpgassets/bugfixes/issue-1582/before.jpgassets/bugfixes/issue-1582/after.jpgassets/bugfixes/issue-1582/compare.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline