fix(pptx): round wrapped lines on the text story grid - #1587
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round each wrapped PowerPoint line's running baseline within its text story,
retaining the fractional phase until that line is painted. Startup continuation
lines now match native PowerPoint within 0.12pt; product continuations move from
179.0/223.0pt to 178.6/223.6pt (native: 178.56/223.68pt).
Use each physical line's largest font size when restoring mixed-size baseline
seats. Native 90% and 100% spacing probes agree within 0.103pt. Move bullets,
links, and underlines with their associated lines while preserving Typst's
wrapping and layout heights, paragraph-end font handling, and fractional
story origins. Top, center, and bottom anchors are covered.
Related issue
Related: #1584. Remaining independent defects: #1581 and #1582.
Testing
cargo test --locked --workspace --no-fail-fast: passed (3487 tests; 15 ignored).All 87 fixed-page text-box tests passed, including RED/GREEN physical-line
rounding and mixed-size regressions using embedded fonts.
Link/underline line-seating regression passed with independent line movements.
cargo clippy --locked --workspace --all-targets -- -D warnings: passed.cargo fmt --all --checkandgit diff --check: passed.Thirteen-page native comparison: layout audit passes at 0.5pt; searchable
text matches (2,184 normalized codepoints, identical codepoint-class census).
All thirteen strict cluster reports pass; 27 clusters have explicit dispositions.
Visual impact
Visual audit
tests/golden_mocks/business/sources/pptx/:01_startup_pitch_en.pptx,03_product_launch_en.pptx,08_marketing_report_en.pptx,09_lecture_ko.pptx, followed by startup slide 2 center/bottom anchor probes. Mapping, reproduction, and hashes:assets/bugfixes/issue-1584/README.md.fixassets/bugfixes/issue-1584/layout-audit.jsonassets/bugfixes/issue-1584/render-clusters-page-1.json,assets/bugfixes/issue-1584/render-clusters-page-2.json,assets/bugfixes/issue-1584/render-clusters-page-3.json,assets/bugfixes/issue-1584/render-clusters-page-4.json,assets/bugfixes/issue-1584/render-clusters-page-5.json,assets/bugfixes/issue-1584/render-clusters-page-6.json,assets/bugfixes/issue-1584/render-clusters-page-7.json,assets/bugfixes/issue-1584/render-clusters-page-8.json,assets/bugfixes/issue-1584/render-clusters-page-9.json,assets/bugfixes/issue-1584/render-clusters-page-10.json,assets/bugfixes/issue-1584/render-clusters-page-11.json,assets/bugfixes/issue-1584/render-clusters-page-12.json,assets/bugfixes/issue-1584/render-clusters-page-13.jsonassets/bugfixes/issue-1584/gt.jpgassets/bugfixes/issue-1584/before.jpgassets/bugfixes/issue-1584/after.jpgassets/bugfixes/issue-1584/compare.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline