fix(charts): preserve declared series marker styling - #1579
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
changed the base branch from
fix/issue-1568-category-baseline
to
main
September 5, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve a chart series marker's declared size, fill, opacity, and outline separately from the plotted series. The budget workbook's selected-period marker previously became a small orange circle because only its symbol was parsed. It now renders as the declared 14pt teal circle with a 0.75pt outline. Plot markers and legend keys share the styling across line, area, combo, and radar charts; absent settings retain existing defaults.
Related: #1185. Remaining independent marker placement and paint-order defects are tracked in #1577 and #1578.
Testing
-D warnings, formatting, and diff checks passed. After integrating the baseline portability follow-up, all 2,846 library tests, workspace clippy, and a locked CLI build pass. The rebuilt PDF has a complete two-page trace identical to the reviewed marker candidate, excluding the PDF filename.Baseline:
7ffaefeb78e5d45d6be0330ee3554b4b3f8ac8d8, including the separate category-baseline correction. The recorded before PDF was built at9ba2c7150a992e66df7790ceeebe3f2ede0976d2; its complete two-page trace is identical to the follow-up baseline. Fixture SHA-256:2b4a2d8dceda58758593c88409875efbda05780559154c02bd13fef4f7a1c65b; Cargo.lock SHA-256:750f50c507b281f84b945b09573333ffa02dc45cddd566481af8535ae101e612.Reference: Open XML SDK's marker child model separates symbol, size, and shape properties;
c:sizeis an integer from 2 through 72 points.Reproduce with
cargo run --locked -p office2pdf-cli -- tests/fixtures/xlsx/issue_1181_fit_to_height.xlsx -o output.pdf --font-path '/Applications/Microsoft Excel.app/Contents/Resources/DFonts'. Runcompare_layout.py GT.pdf output.pdf --audit --fine-shift 0.5 --jsonandcompare_render.py GT.pdf output.pdf --page P --dpi DPI --fine-shift 0.5 --cluster-report PATH --cluster-dispositions PATH --strict-clustersfor both pages (150 and 300 DPI respectively).Visual impact
Visual audit
tests/fixtures/xlsx/issue_1181_fit_to_height.xlsx(SHA-2562b4a2d8dceda58758593c88409875efbda05780559154c02bd13fef4f7a1c65b)fixassets/bugfixes/issue-1185/layout-audit.jsonassets/bugfixes/issue-1185/render-clusters-page-1.json,assets/bugfixes/issue-1185/render-clusters-page-2.jsonassets/bugfixes/issue-1185/gt.jpgassets/bugfixes/issue-1185/before.jpgassets/bugfixes/issue-1185/after.jpgVisual comparison
Native Excel 16.112.3 exports, verified Excel/Quartz PDF provenance. Page 2 at 300 DPI:
The unchanged page-1 native comparison is attached to #1550, #1551, and #1552.
Required inspection
Deviation audit