ci: make forks build only and name checks clearly#14
Closed
Elvis020 wants to merge 1 commit into
Closed
Conversation
Elvis020
changed the title
Restrict fork and fork-origin pull request runs to dependency installation and the Astro build, while keeping GitHub Pages and Cloudflare deployments owned by the canonical devcongress/website repository only. Move Pages write and OIDC permissions onto the Pages deployment job, gate Pages artifact upload and deployment to the canonical repository, gate Cloudflare dry-run validation and production deployment to the canonical repository, and add generic Cloudflare deployment preflight/failure messages so fork logs do not expose raw Wrangler credential diagnostics. Rename the workflow and job display names so build-only jobs appear as Build static site and production jobs appear as Deploy GitHub Pages or Deploy Cloudflare Worker instead of the misleading Build and Deploy wording. Verification: both workflow files were parsed as valid YAML, the diff passed whitespace checks, and the missing-credential Cloudflare preflight path was exercised to confirm it emits the generic Production deployment is not configured message.
Elvis020
force-pushed
the
feature/fork-builds-no-deployments
branch
from
fc2141d to
9a96e87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forks currently run the same
maindeployment workflows asdevcongress/website.Because forks do not have DevCongress deployment secrets or protected environments, their runs fail with deployment errors even though they should only be building the project.
This PR makes deployment ownership explicit and makes the check names match what each job actually does.
Behaviour after this PR
devcongress/websiteWhat changes
Forks become build-only
devcongress/websiterepository can validate or deploy GitHub Pages and Cloudflare.GitHub Pages ownership is isolated
devcongress/website.Cloudflare Workers ownership is isolated
devcongress/websiteonmain.Workflow names are clearer
The GitHub checks now say exactly what each job is doing:
This avoids showing
Build and Deploybeside jobs that are only building, or only deploying.What this does not change
Verification